Merge lp:~chrisccoulson/appmenu-gtk/lp733050 into lp:appmenu-gtk/0.4

Proposed by Chris Coulson
Status: Merged
Merged at revision: 131
Proposed branch: lp:~chrisccoulson/appmenu-gtk/lp733050
Merge into: lp:appmenu-gtk/0.4
Diff against target: 18 lines (+2/-0)
1 file modified
src/bridge.c (+2/-0)
To merge this branch: bzr merge lp:~chrisccoulson/appmenu-gtk/lp733050
Reviewer Review Type Date Requested Status
Ted Gould Pending
Review via email: mp+57334@code.launchpad.net

Description of the change

Fix LP: #733050 - desktop menu doesn't appear.

- Ensure we initialize the GCancellable when creating a new window context
- Don't try to register a window if the menu service isn't online. It can come online whilst we are in the process of doing the initial registration call (which is doomed, anyway), and this means we never register it properly

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/bridge.c'
2--- src/bridge.c 2011-03-10 13:34:55 +0000
3+++ src/bridge.c 2011-04-12 14:41:17 +0000
4@@ -352,6 +352,7 @@
5 {
6 app_menu_bridge_set_show_local (context->bridge, TRUE);
7 }
8+ continue;
9 }
10
11 if (!context->registered && context->server != NULL &&
12@@ -661,6 +662,7 @@
13 {
14 context = g_new0 (AppWindowContext, 1);
15 context->bridge = bridge;
16+ context->cancel = NULL;
17 bridge->priv->windows = g_list_prepend (bridge->priv->windows, context);
18 }
19

Subscribers

People subscribed via source and target branches