Merge ~chris.macnaughton/ubuntu/+source/nfs-ganesha:ubuntu/jammy into ubuntu/+source/nfs-ganesha:ubuntu/jammy-devel

Proposed by Chris MacNaughton
Status: Merged
Merge reported by: Chris MacNaughton
Merged at revision: 3a2f295ee324bcc55e88934de7ffa943012e1605
Proposed branch: ~chris.macnaughton/ubuntu/+source/nfs-ganesha:ubuntu/jammy
Merge into: ubuntu/+source/nfs-ganesha:ubuntu/jammy-devel
Diff against target: 52 lines (+30/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/fix-size-issue-on-arm64.patch (+22/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
James Page (community) Approve
git-ubuntu import Pending
Review via email: mp+432240@code.launchpad.net
To post a comment you must log in.
Revision history for this message
James Page (james-page) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index db1fdd6..8b1697d 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,10 @@
6+nfs-ganesha (3.5-1ubuntu1) jammy; urgency=medium
7+
8+ * d/p/fix-size-issue-on-arm64.patch: Cherry-pick upstream patch to
9+ resolve size issue on ARM64 (LP: #1994699).
10+
11+ -- Chris MacNaughton <chris.macnaughton@ubuntu.com> Wed, 26 Oct 2022 16:16:57 +0000
12+
13 nfs-ganesha (3.5-1build1) jammy; urgency=medium
14
15 * No-change rebuild with new libnfsidmap from src:nfs-utils
16diff --git a/debian/patches/fix-size-issue-on-arm64.patch b/debian/patches/fix-size-issue-on-arm64.patch
17new file mode 100644
18index 0000000..94fe519
19--- /dev/null
20+++ b/debian/patches/fix-size-issue-on-arm64.patch
21@@ -0,0 +1,22 @@
22+From: Chris MacNaughton
23+Description: ganesha-rados-grace: use int type for getopt retval
24+ the implicit conversion of a -1 retval from getopt is interpreted as a
25+ value of 255 on an aarch64 platform, which then causes the default case
26+ of the switch statement to always print a usage message and exit.
27+
28+Origin: upstream, https://github.com/nfs-ganesha/nfs-ganesha/commit/3db6bc0cb75fa85ffcebeda1276d195915b84579
29+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/nfs-ganesha/+bug/1994699
30+
31+Index: nfs-ganesha-3.5/src/tools/ganesha-rados-grace.c
32+===================================================================
33+--- nfs-ganesha-3.5.orig/src/tools/ganesha-rados-grace.c
34++++ nfs-ganesha-3.5/src/tools/ganesha-rados-grace.c
35+@@ -108,7 +108,7 @@ int main(int argc, char * const *argv)
36+ char *pool = DEFAULT_RADOS_GRACE_POOL;
37+ char *oid = DEFAULT_RADOS_GRACE_OID;
38+ char *ns = NULL;
39+- char c;
40++ int c;
41+ const char * const *nodeids;
42+ bool do_add;
43+
44diff --git a/debian/patches/series b/debian/patches/series
45index 50ac51f..ad8c5e1 100644
46--- a/debian/patches/series
47+++ b/debian/patches/series
48@@ -3,3 +3,4 @@ CMakeLists-LIB_INSTALL_DIR.patch
49 add-latomic-linking-as-needed.patch
50 referral-xattr-refresh.patch
51 spelling.patch
52+fix-size-issue-on-arm64.patch

Subscribers

People subscribed via source and target branches