Merge ~chris.macnaughton/ubuntu/+source/ceph:ubuntu/lunar into ~ubuntu-server-dev/ubuntu/+source/ceph:ubuntu/lunar

Proposed by Chris MacNaughton
Status: Merged
Merged at revision: ffa3f1cbcf8e907ca9d41eef9b65f6110b566c76
Proposed branch: ~chris.macnaughton/ubuntu/+source/ceph:ubuntu/lunar
Merge into: ~ubuntu-server-dev/ubuntu/+source/ceph:ubuntu/lunar
Diff against target: 50 lines (+23/-0)
3 files modified
debian/changelog (+6/-0)
debian/patches/enable-python311.patch (+16/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Bryce Harrington Needs Fixing
Review via email: mp+436565@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Bryce Harrington (bryce) wrote :

A couple notes but otherwise glad to see this.

Have you doublechecked that this change is sufficient to resolve the autopkgtest issues? (I'd toss it in a PPA and run autopkgtest against it, but might be ok to just run them locally in lxc).

review: Needs Fixing
Revision history for this message
Chris MacNaughton (chris.macnaughton) wrote :

I am working on this in a PPA as well, incidentally it failed to build, so digging into that now!

Revision history for this message
Chris MacNaughton (chris.macnaughton) wrote :

This has built successfully in a PPA now, and I'm running autopkgtests on it to confirm it functions as expected on lunar-proposed

Revision history for this message
Chris MacNaughton (chris.macnaughton) wrote :

Autopkgtest using this built in a PPA was successful: https://paste.ubuntu.com/p/5xgWjWk3GH/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 12d4058..191b5d9 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,8 +1,14 @@
6 ceph (17.2.0-0ubuntu9) UNRELEASED; urgency=medium
7
8+ [ Peter Sabaini ]
9 * Create package for the cephfs-mirror tool (LP: #2003704)
10 * Fix: add the mgr.nfs package to the core modules (LP: #2003530).
11
12+ [ Chris MacNaughton ]
13+ * d/p/enable-python311.patch: Cherry-pick upstream change to
14+ enable Python 3.11 support (LP: #2004038).
15+ * d/gbp.conf: Update default-branch to lunar.
16+
17 -- Peter Sabaini <peter.sabaini@canonical.com> Tue, 24 Jan 2023 11:17:30 +0100
18
19 ceph (17.2.0-0ubuntu8) lunar; urgency=medium
20diff --git a/debian/patches/enable-python311.patch b/debian/patches/enable-python311.patch
21new file mode 100644
22index 0000000..a84441e
23--- /dev/null
24+++ b/debian/patches/enable-python311.patch
25@@ -0,0 +1,16 @@
26+Description: cmake: add support for python 3.11
27+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/2004038
28+Origin: https://github.com/ceph/ceph/pull/48947
29+Index: ceph/cmake/modules/FindPython/Support.cmake
30+===================================================================
31+--- ceph.orig/cmake/modules/FindPython/Support.cmake
32++++ ceph/cmake/modules/FindPython/Support.cmake
33+@@ -17,7 +17,7 @@ if (NOT DEFINED _${_PYTHON_PREFIX}_REQUI
34+ message (FATAL_ERROR "FindPython: INTERNAL ERROR")
35+ endif()
36+ if (_${_PYTHON_PREFIX}_REQUIRED_VERSION_MAJOR EQUAL 3)
37+- set(_${_PYTHON_PREFIX}_VERSIONS 3.10 3.9 3.8 3.7 3.6 3.5 3.4 3.3 3.2 3.1 3.0)
38++ set(_${_PYTHON_PREFIX}_VERSIONS 3.11 3.10 3.9 3.8 3.7 3.6 3.5 3.4 3.3 3.2 3.1 3.0)
39+ elseif (_${_PYTHON_PREFIX}_REQUIRED_VERSION_MAJOR EQUAL 2)
40+ set(_${_PYTHON_PREFIX}_VERSIONS 2.7 2.6 2.5 2.4 2.3 2.2 2.1 2.0)
41+ else()
42diff --git a/debian/patches/series b/debian/patches/series
43index 0c438d7..303105c 100644
44--- a/debian/patches/series
45+++ b/debian/patches/series
46@@ -1,3 +1,4 @@
47+enable-python311.patch
48 lp1986747-fix-osd-class-dir.patch
49 enable-strsignal.patch
50 update-java-source-target-flags.patch

Subscribers

People subscribed via source and target branches