Merge ~chris.macnaughton/charm-telegraf:master into ~telegraf-charmers/charm-telegraf:master

Proposed by Chris MacNaughton
Status: Rejected
Rejected by: Tom Haddon
Proposed branch: ~chris.macnaughton/charm-telegraf:master
Merge into: ~telegraf-charmers/charm-telegraf:master
Diff against target: 15 lines (+2/-0)
1 file modified
metadata.yaml (+2/-0)
Reviewer Review Type Date Requested Status
Stuart Bishop (community) Disapprove
Review via email: mp+331442@code.launchpad.net

Description of the change

This closes bug #1718259

To post a comment you must log in.
Revision history for this message
Stuart Bishop (stub) wrote :

This is a duplicate of https://code.launchpad.net/~dmitriis/telegraf-charm/+git/telegraf-charm/+merge/331171 , which needs some careful testing.

review: Disapprove
Revision history for this message
Tom Haddon (mthaddon) wrote :

Marking as rejected per the comment above about this being a duplicate of that other MP

Unmerged commits

940c229... by Chris MacNaughton

modify the database copes to be container

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/metadata.yaml b/metadata.yaml
2index a33ad3f..338e66c 100644
3--- a/metadata.yaml
4+++ b/metadata.yaml
5@@ -37,8 +37,10 @@ subordinate: true
6 requires:
7 mysql:
8 interface: mysql-root
9+ scope: container
10 postgresql:
11 interface: pgsql
12+ scope: container
13 mongodb:
14 interface: mongodb
15 scope: container

Subscribers

People subscribed via source and target branches

to all changes: