Merge lp:~chris.gagnon/ubuntu-ui-toolkit/autopilot_wait_for_popover into lp:ubuntu-ui-toolkit/staging

Proposed by Chris Gagnon
Status: Merged
Approved by: Tim Peeters
Approved revision: 1019
Merged at revision: 1058
Proposed branch: lp:~chris.gagnon/ubuntu-ui-toolkit/autopilot_wait_for_popover
Merge into: lp:ubuntu-ui-toolkit/staging
Diff against target: 12 lines (+1/-1)
1 file modified
tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_mainview.py (+1/-1)
To merge this branch: bzr merge lp:~chris.gagnon/ubuntu-ui-toolkit/autopilot_wait_for_popover
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Tim Peeters Approve
Leo Arias Pending
Review via email: mp+219935@code.launchpad.net

This proposal supersedes a proposal from 2014-05-14.

Commit message

wait for autopilot popover

To post a comment you must log in.
Revision history for this message
Leo Arias (elopio) wrote : Posted in a previous version of this proposal

looks good.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Approve (continuous-integration)
Revision history for this message
Tim Peeters (tpeeters) wrote : Posted in a previous version of this proposal

please re-submit for merging into lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/staging

Revision history for this message
Tim Peeters (tpeeters) : Posted in a previous version of this proposal
review: Needs Resubmitting
Revision history for this message
Tim Peeters (tpeeters) wrote :

thanks

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:1019
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/242/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/296
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/270
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-amd64-ci/74
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-armhf-ci/74
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-armhf-ci/74/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-i386-ci/74
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/781
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/590
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/590/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/7295
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/244
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/337
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/337/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/242/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_mainview.py'
2--- tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_mainview.py 2014-04-30 18:17:32 +0000
3+++ tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_mainview.py 2014-05-17 14:19:17 +0000
4@@ -169,7 +169,7 @@
5 :parameter object_name: The QML objectName property of the popover.
6
7 """
8- return self.select_single(
9+ return self.wait_select_single(
10 popups.ActionSelectionPopover, objectName=object_name)
11
12 @autopilot_logging.log_action(logger.info)

Subscribers

People subscribed via source and target branches