Merge lp:~chris.gagnon/ubuntu-ui-toolkit/autopilot_wait_for_popover into lp:ubuntu-ui-toolkit

Proposed by Chris Gagnon
Status: Superseded
Proposed branch: lp:~chris.gagnon/ubuntu-ui-toolkit/autopilot_wait_for_popover
Merge into: lp:ubuntu-ui-toolkit
Diff against target: 12 lines (+1/-1)
1 file modified
tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_mainview.py (+1/-1)
To merge this branch: bzr merge lp:~chris.gagnon/ubuntu-ui-toolkit/autopilot_wait_for_popover
Reviewer Review Type Date Requested Status
Tim Peeters Needs Resubmitting
PS Jenkins bot continuous-integration Approve
Leo Arias (community) Approve
Review via email: mp+219601@code.launchpad.net

This proposal has been superseded by a proposal from 2014-05-17.

Commit message

wait for popover in autopilot custom proxy object

To post a comment you must log in.
Revision history for this message
Leo Arias (elopio) wrote :

looks good.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Tim Peeters (tpeeters) wrote :

please re-submit for merging into lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/staging

Revision history for this message
Tim Peeters (tpeeters) :
review: Needs Resubmitting

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_mainview.py'
2--- tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_mainview.py 2014-04-30 18:17:32 +0000
3+++ tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_mainview.py 2014-05-14 21:21:05 +0000
4@@ -169,7 +169,7 @@
5 :parameter object_name: The QML objectName property of the popover.
6
7 """
8- return self.select_single(
9+ return self.wait_select_single(
10 popups.ActionSelectionPopover, objectName=object_name)
11
12 @autopilot_logging.log_action(logger.info)

Subscribers

People subscribed via source and target branches

to status/vote changes: