Merge lp:~chris.gagnon/ubuntu-calendar-app/fix_1293489 into lp:ubuntu-calendar-app

[Chris Gagnon]

use wait_select_single for the main_view instead of select_single in the autopilot tests

use wait_select_single for the main_view instead of select_single

[Nicholas Skaggs (nskaggs)]

We found this to be useful for clock as well; does this actually solve everything?

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/ubuntu-calendar-app-autolanding/139/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-trusty/1803
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-autolanding/139
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-saucy-amd64-autolanding/139
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-trusty-amd64-autolanding/79

review: Needs Fixing (continuous-integration)

[Victor Thompson (vthompson)]

This does allow the tests to run, but test_new_event still fails. I ran it twice with the same result:

Starting test calendar_app.tests.test_calendar.TestMainView.test_new_event (with touch)
...
Traceback (most recent call last):
File "/home/phablet/autopilot/calendar_app/tests/test_calendar.py", line 89, in test_new_event
self.assertThat(people_field.activeFocus, Eventually(Equals(True)))
File "/usr/lib/python2.7/dist-packages/testtools/testcase.py", line 406, in assertThat
raise mismatch_error
MismatchError: After 10.0 seconds test on NewEventEntryField.activeFocus failed: True != dbus.Boolean(False, variant_level=1)

Ran 1 test in 142.140s
FAILED (failures=1)

review: Needs Fixing

[Nicholas Skaggs (nskaggs)]

Yes, the issue with new event is twofold. First, the field is offscreen. Second, once saved, the assertion to check for a new event fails randomly when the event overlaps the screen. I'm unsure if this always happens or if it's only at a certain time. On a flo, neither of these issues exist due to the larger screen.

[Victor Thompson (vthompson)]

Actually, even the wait_select_single doesn't seem to solve the issue 100% of the time.

[Victor Thompson (vthompson)]

I have a MR with a change [1] that fixes the field being offscreen:

+ # scroll to make bottom fields visible
+ self.pointing_device.move_to_object(location_field)
+ x1 = self.main_view.height/2
+ y1 = self.main_view.width/2
+ self.pointing_device.drag(x1, y1, x1, y1 - y1/2)
+

[1] https://code.launchpad.net/~vthompson/ubuntu-calendar-app/scroll-in-test/+merge/211856

[Nicholas Skaggs (nskaggs)]

As this changes is now in trunk, it's no longer needed.

review: Disapprove

Unmerged revisions

213. By Chris Gagnon on 2014-03-19

wait for the main_view

=== modified file 'tests/autopilot/calendar_app/tests/__init__.py'
--- tests/autopilot/calendar_app/tests/__init__.py	2014-01-31 21:15:52 +0000
+++ tests/autopilot/calendar_app/tests/__init__.py	2014-03-19 16:52:55 +0000
@@ -122,4 +122,4 @@
 
     @property
     def main_view(self):
-        return self.app.select_single(emulators.MainView)
+        return self.app.wait_select_single(emulators.MainView)