Merge lp:~chris.gagnon/qa-coverage-dashboard/stagger-x-axis into lp:qa-coverage-dashboard

Proposed by Chris Gagnon on 2014-05-19
Status: Needs review
Proposed branch: lp:~chris.gagnon/qa-coverage-dashboard/stagger-x-axis
Merge into: lp:qa-coverage-dashboard
Diff against target: 45 lines (+14/-9)
2 files modified
gaps/management/commands/jenkins_pull_coverage.py (+0/-3)
gaps/static/gaps/js/gaps_chart.js (+14/-6)
To merge this branch: bzr merge lp:~chris.gagnon/qa-coverage-dashboard/stagger-x-axis
Reviewer Review Type Date Requested Status
gaps 2014-05-19 Pending
Review via email: mp+220080@code.launchpad.net
To post a comment you must log in.
776. By Chris Gagnon on 2014-05-22

fix indent

Unmerged revisions

776. By Chris Gagnon on 2014-05-22

fix indent

775. By Chris Gagnon on 2014-05-19

stagger labels on x axis, make code easier to read

774. By Chris Gagnon on 2014-05-19

remove old commented out code

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'gaps/management/commands/jenkins_pull_coverage.py'
2--- gaps/management/commands/jenkins_pull_coverage.py 2014-05-19 12:06:12 +0000
3+++ gaps/management/commands/jenkins_pull_coverage.py 2014-05-22 13:44:23 +0000
4@@ -30,7 +30,4 @@
5 from c2dconfigutils.cu2dOutputCi import OutputCi
6
7 get_coverage = OutputCi()
8- #if options['just_last_build']:
9- # get_coverage(BASEDIR, True)
10- #else:
11 get_coverage(BASEDIR, options['just_last_build'])
12
13=== modified file 'gaps/static/gaps/js/gaps_chart.js'
14--- gaps/static/gaps/js/gaps_chart.js 2014-04-04 21:10:20 +0000
15+++ gaps/static/gaps/js/gaps_chart.js 2014-05-22 13:44:23 +0000
16@@ -2,16 +2,24 @@
17 d3.json(data_url, function(data) {
18 nv.addGraph(function() {
19 var chart = nv.models.lineChart()
20- .width(1100).height(400);
21+ .width(1100).height(400);
22+
23 chart.forceY([0, 1]);
24+
25 chart.xAxis
26- .axisLabel('Date')
27- .tickFormat(function(d){return d3.time.format('%Y%m%d')(new Date(d * 1000));})
28+ .axisLabel('Date')
29+ .tickFormat(function(d){return d3.time.format('%Y%m%d')(new Date(d * 1000));})
30+ .staggerLabels(true);
31
32 chart.yAxis
33- .axisLabel('%')
34- .tickFormat(d3.format('%'))
35- d3.select('#line-chart svg').datum(data).transition().duration(500).call(chart);
36+ .axisLabel('%')
37+ .tickFormat(d3.format('%'));
38+
39+ d3.select('#line-chart svg')
40+ .datum(data)
41+ .transition()
42+ .duration(500)
43+ .call(chart);
44
45 nv.utils.windowResize(chart.update);
46

Subscribers

People subscribed via source and target branches

to all changes: