Code review comment for lp:~chris.gagnon/qa-coverage-dashboard/only-get-last-build-from-jenkins

Revision history for this message
Allan LeSage (allanlesage) wrote :

I like the tests, they're good. I personally like when assertions go like this: assertEqual(42, my_var) , but apparently there's no consensus on that. A couple of things:

* Can we not test those integers as strings?
* For ll. 68-71, I think you can not do the conditional and just pass through the var.

Otherwise looks good.

review: Needs Fixing

« Back to merge proposal