Merge lp:~chris.gagnon/helipad/graphics-sort-for-x-xmir-order into lp:helipad/graphics

Proposed by Chris Gagnon
Status: Merged
Approved by: Joe Talbott
Approved revision: 33
Merged at revision: 33
Proposed branch: lp:~chris.gagnon/helipad/graphics-sort-for-x-xmir-order
Merge into: lp:helipad/graphics
Diff against target: 53 lines (+6/-4)
3 files modified
api.py (+1/-0)
management/commands/jenkins_pull_phoronix.py (+2/-2)
static/graphics/js/phoronix.js (+3/-2)
To merge this branch: bzr merge lp:~chris.gagnon/helipad/graphics-sort-for-x-xmir-order
Reviewer Review Type Date Requested Status
Joe Talbott Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+188840@code.launchpad.net

Commit message

sort testnames so guitoolkits has the same order as openarena and nexuiz

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:33
http://s-jenkins:8080/job/helipad-graphics-ci/40/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins:8080/job/helipad-graphics-ci/40/rebuild

review: Approve (continuous-integration)
Revision history for this message
Joe Talbott (joetalbott) wrote :

Looks okay to me.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'api.py'
2--- api.py 2013-09-23 19:08:33 +0000
3+++ api.py 2013-10-02 13:45:33 +0000
4@@ -65,6 +65,7 @@
5 machine__name__contains=machine_filter,
6 test_resolution=resolution_filter,
7 ).distinct('name')]
8+ test_names.sort()
9
10 results = GraphicsMetric.objects.filter(
11 name__contains=benchmark_filter,
12
13=== modified file 'management/commands/jenkins_pull_phoronix.py'
14--- management/commands/jenkins_pull_phoronix.py 2013-09-25 13:46:25 +0000
15+++ management/commands/jenkins_pull_phoronix.py 2013-10-02 13:45:33 +0000
16@@ -45,7 +45,7 @@
17 jenk_build.jenkins_build.build_number for jenk_build in
18 GraphicsMetric.objects.filter(
19 jenkins_build__job__name__exact=jenkins_job_name)]
20- sorted(last_build, reverse=True)
21+ sorted(last_build)
22
23 # If there is no last build give it a value of 0
24 if last_build == []:
25@@ -54,7 +54,7 @@
26 logger.debug('last build: {}'.format(last_build))
27 url_list = jenkins_pull.url_artifact_list(jenkins_job_name,
28 artifact_name,
29- last_build[0])
30+ last_build[-1])
31 logger.debug('url_list: {}'.format(url_list))
32 if url_list is not False:
33 for url_file in url_list:
34
35=== modified file 'static/graphics/js/phoronix.js'
36--- static/graphics/js/phoronix.js 2013-09-27 17:19:42 +0000
37+++ static/graphics/js/phoronix.js 2013-10-02 13:45:33 +0000
38@@ -90,12 +90,13 @@
39 for (var key in data) {
40 var key_name = data[key].key;
41 if(key_name.indexOf('gui-toolkit') != -1){
42- // TODO somereason not filtering GtkDrawingArea fix it
43 key_name = key_name.replace(
44 / |gui-toolkit-|GtkPerf-|le-|-he|ps-/gi, '');
45 data[key].key = key_name;
46- }; // if key_name index
47+ };
48 }; // for key in data
49+
50+
51 add_chart = nv.addGraph(function() {
52
53 var chart = nv.models.multiBarChart()

Subscribers

People subscribed via source and target branches

to all changes: