Merge lp:~chris-gondolin/charm-helpers/fetch-bzr-revnos into lp:charm-helpers
Proposed by
Chris Stratford
Status: | Merged |
---|---|
Merged at revision: | 587 |
Proposed branch: | lp:~chris-gondolin/charm-helpers/fetch-bzr-revnos |
Merge into: | lp:charm-helpers |
Diff against target: |
40 lines (+13/-5) 1 file modified
charmhelpers/fetch/bzrurl.py (+13/-5) |
To merge this branch: | bzr merge lp:~chris-gondolin/charm-helpers/fetch-bzr-revnos |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Stuart Bishop (community) | Approve | ||
Review via email: mp+289942@code.launchpad.net |
Description of the change
Adds the option to specify a revno when fetching from a bzr repo.
Updated and resubmitted, since the code the original merge request was made against (8 months ago) has now changed.
To post a comment you must log in.
Looks fine, but there is no test for the new arguments. I've added the trivial test, which demonstrated a bug (revno needs to be cast to a string), which I have also fixed.