Merge lp:~chocanto/file-qml-plugin/debian into lp:file-qml-plugin

Proposed by Anthony Granger
Status: Merged
Merged at revision: 6
Proposed branch: lp:~chocanto/file-qml-plugin/debian
Merge into: lp:file-qml-plugin
Diff against target: 111 lines (+80/-0)
6 files modified
debian/changelog (+5/-0)
debian/compat (+1/-0)
debian/control (+17/-0)
debian/copyright (+45/-0)
debian/rules (+11/-0)
debian/source/format (+1/-0)
To merge this branch: bzr merge lp:~chocanto/file-qml-plugin/debian
Reviewer Review Type Date Requested Status
Nekhelesh Ramananthan (community) Needs Information
Review via email: mp+187020@code.launchpad.net

Commit message

Debian packaging

Description of the change

Initial merge of debian packaging

To post a comment you must log in.
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

I start this review by stating that I am no debian expert. I am merely comparing this debian folder with the clock app and my own judgement. Please fix the following in a separate commit so that it is easy to see if they have been fixed.

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

25 +Maintainer: Ubuntu App Cats <email address hidden>

I am wondering why the Ubuntu App Cats is the maintainer of this library. Shouldn't it be you? I guess you need to decide if you are going to merge it to the core apps PPA in which case the above is correct, otherwise you need to change this.

review: Needs Information
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

48 +Files: *
49 +Copyright: 2013 Canonical Ltd.
50 +License: GPL-3

Here you can remove the 2013 Canonical Ltd. and replace it with the contributors's names in the format,

Name <email>

The rest of the copyright seems okay.

review: Needs Fixing
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

45 +Upstream-Name: qtdeclarative5-poppler-qml-plugin

It would be preferable if this upstream package name is the same as the soruce package name itself.

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

34 +Architecture: any

Please cross check this with others. Since the qml plugin is c++, we need to be careful about this.

review: Needs Information
lp:~chocanto/file-qml-plugin/debian updated
8. By Anthony Granger

Change maintainer of the package and some informations in the copyright file

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added directory 'debian'
2=== added file 'debian/changelog'
3--- debian/changelog 1970-01-01 00:00:00 +0000
4+++ debian/changelog 2013-09-24 18:33:53 +0000
5@@ -0,0 +1,5 @@
6+file-qml-plugin (0.1-1) saucy; urgency=low
7+
8+ * Initial release
9+
10+ -- Granger Anthony <grangeranthony@gmail.com> Mon, 23 Sep 2013 14:51:00 +0200
11
12=== added file 'debian/compat'
13--- debian/compat 1970-01-01 00:00:00 +0000
14+++ debian/compat 2013-09-24 18:33:53 +0000
15@@ -0,0 +1,1 @@
16+8
17
18=== added file 'debian/control'
19--- debian/control 1970-01-01 00:00:00 +0000
20+++ debian/control 2013-09-24 18:33:53 +0000
21@@ -0,0 +1,17 @@
22+Source: file-qml-plugin
23+Section: libs
24+Priority: extra
25+Maintainer: Anthony Granger <grangeranthony@gmail.com>
26+Build-Depends: debhelper (>= 9),
27+ qt5-default,
28+ qtbase5-dev,
29+ qtdeclarative5-dev
30+Standards-Version: 3.9.4
31+Homepage: https://launchpad.net/file-qml-plugin
32+Vcs-Bzr: https://code.launchpad.net/~chocanto/file-qml-plugin/trunk
33+
34+Architecture: any
35+Package: file-qml-plugin
36+Depends: ${shlibs:Depends}, ${misc:Depends}
37+Description: File access plugin for QML
38+ This package contains a simple QML plugin to read a file.
39
40=== added file 'debian/copyright'
41--- debian/copyright 1970-01-01 00:00:00 +0000
42+++ debian/copyright 2013-09-24 18:33:53 +0000
43@@ -0,0 +1,45 @@
44+Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
45+Upstream-Name: file-qml-plugin
46+Source:
47+
48+Files: *
49+Copyright: Anthony Granger <grangeranthony@gmail.com>
50+License: GPL-3
51+
52+Files: debian/*
53+Copyright: Anthony Granger <grangeranthony@gmail.com>
54+License: LGPL-3
55+
56+License: GPL-3
57+ This package is free software; you can redistribute it and/or
58+ modify it under the terms of the GNU General Public
59+ License as published by the Free Software Foundation; either
60+ version 3 of the License.
61+ .
62+ This package is distributed in the hope that it will be useful,
63+ but WITHOUT ANY WARRANTY; without even the implied warranty of
64+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
65+ General Public License for more details.
66+ .
67+ You should have received a copy of the GNU General Public License
68+ along with this program. If not, see <http://www.gnu.org/licenses/>.
69+ .
70+ On Debian systems, the complete text of the GNU General
71+ Public License can be found in "/usr/share/common-licenses/GPL-3".
72+
73+License: LGPL-3
74+ This package is free software; you can redistribute it and/or
75+ modify it under the terms of the GNU Lesser General Public
76+ License as published by the Free Software Foundation; either
77+ version 3 of the License.
78+ .
79+ This package is distributed in the hope that it will be useful,
80+ but WITHOUT ANY WARRANTY; without even the implied warranty of
81+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
82+ Lesser General Public License for more details.
83+ .
84+ You should have received a copy of the GNU General Public License
85+ along with this program. If not, see <http://www.gnu.org/licenses/>.
86+ .
87+ On Debian systems, the complete text of the GNU Lesser General
88+ Public License can be found in "/usr/share/common-licenses/LGPL-3".
89
90=== added file 'debian/rules'
91--- debian/rules 1970-01-01 00:00:00 +0000
92+++ debian/rules 2013-09-24 18:33:53 +0000
93@@ -0,0 +1,11 @@
94+#!/usr/bin/make -f
95+# -*- makefile -*-
96+
97+# Uncomment this to turn on verbose mode.
98+#export DH_VERBOSE=1
99+
100+%:
101+ dh $@
102+
103+override_dh_install:
104+ dh_install --fail-missing
105
106=== added directory 'debian/source'
107=== added file 'debian/source/format'
108--- debian/source/format 1970-01-01 00:00:00 +0000
109+++ debian/source/format 2013-09-24 18:33:53 +0000
110@@ -0,0 +1,1 @@
111+1.0

Subscribers

People subscribed via source and target branches

to all changes: