Merge lp:~chipaca/unity-lens-video/remote-recommendations-are-remote into lp:unity-lens-video/remote-videos-scope-trunk

Proposed by John Lenton
Status: Merged
Approved by: David Callé
Approved revision: 27
Merged at revision: 27
Proposed branch: lp:~chipaca/unity-lens-video/remote-recommendations-are-remote
Merge into: lp:unity-lens-video/remote-videos-scope-trunk
Diff against target: 25 lines (+3/-4)
1 file modified
src/unity-scope-video-remote (+3/-4)
To merge this branch: bzr merge lp:~chipaca/unity-lens-video/remote-recommendations-are-remote
Reviewer Review Type Date Requested Status
David Callé Pending
Review via email: mp+94378@code.launchpad.net

Commit message

This lets empty searches through, so we get recommendations.

Description of the change

This lets empty searches through, so we get recommendations.

A different branch would be to cache this. A quirk of that would be that we need/want to have it per source. Some smartness needed.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/rules' (properties changed: -x to +x)
2=== modified file 'src/unity-scope-video-remote'
3--- src/unity-scope-video-remote 2012-02-23 11:01:39 +0000
4+++ src/unity-scope-video-remote 2012-02-23 13:58:19 +0000
5@@ -112,9 +112,8 @@
6 sources = ','.join(sources)
7 # Ensure that we are not in Global search
8 if search_type is Unity.SearchType.DEFAULT:
9- if len(search_string) > 0:
10- self.update_results_model(search_string, model, sources)
11- model.flush_revision_queue()
12+ self.update_results_model(search_string, model, sources)
13+ model.flush_revision_queue()
14 if search:
15 search.finished()
16
17@@ -140,7 +139,7 @@
18 """Query the server with the search string and the list of sources."""
19 query = dict(q=search)
20 if sources:
21- query['sources'] = sources
22+ query['sources'] = sources.encode("utf-8")
23 query = urllib.urlencode(query)
24 url = "%s/search?%s" % (SERVER, query)
25 print "Querying the server:", url

Subscribers

People subscribed via source and target branches

to all changes: