Merge lp:~chipaca/ubuntuone-client/nautilus-ppage into lp:ubuntuone-client
Proposed by
John Lenton
Status: | Rejected |
---|---|
Rejected by: | John Lenton |
Proposed branch: | lp:~chipaca/ubuntuone-client/nautilus-ppage |
Merge into: | lp:ubuntuone-client |
Diff against target: |
167 lines (+138/-0) 1 file modified
nautilus/ubuntuone-nautilus.c (+138/-0) |
To merge this branch: | bzr merge lp:~chipaca/ubuntuone-client/nautilus-ppage |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Rodrigo Moya (community) | Needs Fixing | ||
Review via email: mp+32295@code.launchpad.net |
Description of the change
these are not the property pages you are looking for.
To post a comment you must log in.
Unmerged revisions
- 627. By John Lenton
-
second half of the ppage work
- 626. By John Lenton
-
whee, a page provider
yay! But a few things:
ubuntuone- nautilus. c is too crowded, so could you move the property page creation/code to its own file, like location-widget.c does?
If the data is not editable, why not just use a label? See the 'Audio' property page for MP3's, it has sections (in bold) and then the different data in labels, with nice italic strings for the "field" names. Something like that would look much better.
Also, the 'Ubuntu One' page shows for every folder/file, whether it's a UDF/inside a UDF or not.