Merge lp:~chipaca/ubuntuone-client/add-instructional-text into lp:ubuntuone-client

Proposed by John Lenton
Status: Merged
Approved by: Guillermo Gonzalez
Approved revision: 455
Merged at revision: not available
Proposed branch: lp:~chipaca/ubuntuone-client/add-instructional-text
Merge into: lp:ubuntuone-client
Diff against target: 33 lines (+13/-3)
1 file modified
bin/ubuntuone-preferences (+13/-3)
To merge this branch: bzr merge lp:~chipaca/ubuntuone-client/add-instructional-text
Reviewer Review Type Date Requested Status
Guillermo Gonzalez Approve
Facundo Batista (community) Approve
Review via email: mp+22382@code.launchpad.net

Commit message

add instructional text to devices and services tabs

Description of the change

Oooh, look, instructional texts!

To post a comment you must log in.
Revision history for this message
John O'Brien (jdobrien) wrote :

Looks good. I am wondering if the following text really makes it clear.

"Selecting additional synchronizing features contributes to data stored with Ubuntu One"

Is this a warning that I am going to use up may space, and invitation to use more, or is this just a way of controlling what is synced with Ubuntu One.

Revision history for this message
Facundo Batista (facundo) wrote :

Works.

review: Approve
455. By John Lenton

changes to the text as per mattgriffin

Revision history for this message
Guillermo Gonzalez (verterok) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bin/ubuntuone-preferences'
2--- bin/ubuntuone-preferences 2010-03-26 19:36:48 +0000
3+++ bin/ubuntuone-preferences 2010-03-29 19:02:25 +0000
4@@ -181,9 +181,8 @@
5 self.status_label = gtk.Label("")
6 self.attach(self.status_label, 0, 3, 2, 3)
7
8- self.description = gtk.Label(_("The devices connected to with your"
9- " personal cloud network"
10- " are listed below"))
11+ self.description = gtk.Label(_("The following devices synchronize"
12+ " with your Ubuntu One account."))
13 self.description.set_alignment(0., .5)
14 self.description.set_line_wrap(True)
15 self.attach(self.description, 0, 3, 0, 1, xpadding=12, ypadding=12)
16@@ -781,6 +780,17 @@
17 self.notebook.set_tab_label_text(services, _("Services"))
18 services.show()
19
20+ label = gtk.Label()
21+ label.set_markup(
22+ _("Ubuntu One sync options\n"
23+ "<small>Choose services to synchronize"
24+ " with this computer</small>"))
25+ label.set_alignment(0., .5)
26+ label.set_padding(12, 6)
27+ label.set_line_wrap(True)
28+ services.pack_start(label, False, False)
29+ label.show()
30+
31 self.bookmarks_check = gtk.CheckButton(_("_Bookmarks"))
32 self.bookmarks_check.set_data('dbname', 'bookmarks')
33 self.bookmarks_check.connect('toggled', self.__db_check_toggled)

Subscribers

People subscribed via source and target branches