Merge lp:~chipaca/ubuntu-system-settings/wider-grid into lp:ubuntu-system-settings

Proposed by John Lenton
Status: Merged
Approved by: Iain Lane
Approved revision: 863
Merged at revision: 865
Proposed branch: lp:~chipaca/ubuntu-system-settings/wider-grid
Merge into: lp:ubuntu-system-settings
Diff against target: 12 lines (+1/-1)
1 file modified
src/qml/CategoryGrid.qml (+1/-1)
To merge this branch: bzr merge lp:~chipaca/ubuntu-system-settings/wider-grid
Reviewer Review Type Date Requested Status
Iain Lane Approve
PS Jenkins bot continuous-integration Needs Fixing
Ken VanDine Approve
Matthew Paul Thomas (community) design Approve
Review via email: mp+229616@code.launchpad.net

Commit message

This makes the category grid a little bit looser.

Description of the change

This makes the category grid a little bit looser.

To post a comment you must log in.
Revision history for this message
John Lenton (chipaca) wrote :
Revision history for this message
Matthew Paul Thomas (mpt) wrote :

This looks better, thanks.

review: Approve (design)
Revision history for this message
Ken VanDine (ken-vandine) wrote :

Looks great!

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:863
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/1151/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/3037
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/2411
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-amd64-ci/343
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-armhf-ci/343
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-armhf-ci/343/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-i386-ci/343
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/3080
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/4280
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/4280/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/11003
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/1995
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/2678
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/2678/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/1151/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Iain Lane (laney) wrote :

ty

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/qml/CategoryGrid.qml'
2--- src/qml/CategoryGrid.qml 2014-07-22 11:21:43 +0000
3+++ src/qml/CategoryGrid.qml 2014-08-05 13:34:21 +0000
4@@ -22,7 +22,7 @@
5 }
6
7 Grid {
8- property int itemWidth: units.gu(9)
9+ property int itemWidth: units.gu(12)
10
11 // The amount of whitespace, including column spacing
12 property int space: parent.width - columns * itemWidth

Subscribers

People subscribed via source and target branches