Ubuntu Push Notifications

Merge lp:~chipaca/ubuntu-push/less-piiquant into lp:ubuntu-push/automatic

  1. less-piiquant
  2. Merge into automatic
Proposed by John Lenton
Status: Merged
Approved by: John Lenton
Approved revision: 105
Merged at revision: 105
Proposed branch: lp:~chipaca/ubuntu-push/less-piiquant
Merge into: lp:ubuntu-push/automatic
Diff against target: 12 lines (+1/-1)
1 file modified
client/session/session.go (+1/-1)
To merge this branch: bzr merge lp:~chipaca/ubuntu-push/less-piiquant
Reviewer Review Type Date Requested Status
Samuele Pedroni Approve
Review via email: mp+214190@code.launchpad.net

Commit message

s/LocalAddr/RemoteAddr/ in client/session, to not log PII.

Description of the change

s/LocalAddr/RemoteAddr/ in client/session, to not log PII.

To post a comment you must log in.
Revision history for this message
Samuele Pedroni (pedronis) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'client/session/session.go'
2--- client/session/session.go 2014-04-02 13:53:15 +0000
3+++ client/session/session.go 2014-04-04 09:28:19 +0000
4@@ -401,7 +401,7 @@
5 }
6 sess.proto = proto
7 sess.pingInterval = pingInterval
8- sess.Log.Debugf("Connected %v.", conn.LocalAddr())
9+ sess.Log.Debugf("Connected %v.", conn.RemoteAddr())
10 sess.started() // deals with choosing which host to retry with as well
11 return nil
12 }

Subscribers

People subscribed via source and target branches