lp:~chipaca/ubuntu-push/client-session-redialer-mash

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:ubuntu-push at revision 54

Samuele Pedroni: Approve on 2014-02-05

Diff: 709 lines (+267/-160)

10 files modified

bus/connectivity/connectivity.go (+2/-1)
bus/endpoint.go (+0/-7)
bus/testing/testing_endpoint.go (+0/-3)
bus/testing/testing_endpoint_test.go (+0/-6)
client/client.go (+21/-48)
client/client_test.go (+0/-7)
client/session/session.go (+34/-1)
client/session/session_test.go (+76/-1)
util/redialer.go (+71/-36)
util/redialer_test.go (+63/-50)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1276199: move session redial logic into session

High

Fix Released

Link a bug report

Related blueprints

56. By John Lenton on 2014-02-05

stopRedial

55. By John Lenton on 2014-02-05

tested the closing of the retrier by session.Close and session.AutoRedial

54. By John Lenton on 2014-02-05

made AutoRedialer an interface

53. By John Lenton on 2014-02-05

Reworked util/redialer, so i could refactor session, so i could fix client. Or something like that anyway.

52. By Samuele Pedroni on 2014-02-04

[r=chipaca] base the simple logger only on having a log.Logger-style Output(); given this we can introduce a testing.TestLogger that does redirecting of logs to the gocheck.C object if wired in SetUpTest and also does its own capture

51. By John Lenton on 2014-02-04

[r=pedronis] Several things:
* features:
  * Client.doLoop, the puppet master.
* fixes and cleanups:
  * added log_level to client config
  * added the mysterious sessionRetryCh, used in doLoop to avoid a rather common starvation scenario.
  * found a way not to panic out in initSession (not that it's much better)
  * unified logging in the client tests a bit
  * added logging to session's start error states.

50. By John Lenton on 2014-02-04

[r=pedronis] Several things:
* features:
  * bus/testing/'s Endpoint now tracks Calls; call bus/testing.GetCallCargs(endp) to get the list.
  * Client.handleErr, Client.handleNotification and Client.handleClick (and tests)
* cleanups:
  * renamed client's Client's connState to hasConnectivity
  * split out code from handleConnState into initSession/connectSession/disconnectSession

49. By John Lenton on 2014-02-04

[r=pedronis] added handleConnState

48. By John Lenton on 2014-02-04

[r=pedronis] Part 4: added State to client/session, to aid in testing some aspects of
this.

47. By Samuele Pedroni on 2014-02-04

[r=chipaca] fix corner cases like client level too ahead etc, with acceptance tests