Merge lp:~chipaca/snapweb/seriously-build-ok into lp:~snappy-dev/snapweb/trunk

Proposed by John Lenton
Status: Superseded
Proposed branch: lp:~chipaca/snapweb/seriously-build-ok
Merge into: lp:~snappy-dev/snapweb/trunk
Prerequisite: lp:~chipaca/snapweb/build-again-plz
Diff against target: 119 lines (+43/-12)
3 files modified
build.sh (+35/-9)
pkg/meta/package.yaml (+2/-2)
pkg/snappyd (+6/-1)
To merge this branch: bzr merge lp:~chipaca/snapweb/seriously-build-ok
Reviewer Review Type Date Requested Status
Sergio Schvezov Approve
Review via email: mp+273062@code.launchpad.net

This proposal has been superseded by a proposal from 2015-11-05.

Commit message

Tweaks and fixes to build and package.

To post a comment you must log in.
Revision history for this message
Sergio Schvezov (sergiusens) :
review: Approve
163. By John Lenton

fxi typo

Unmerged revisions

163. By John Lenton

fxi typo

162. By John Lenton

silly tweaks to build and package

161. By John Lenton

update package version

160. By John Lenton

build again, ok? ta

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'build.sh'
2--- build.sh 2015-05-26 13:34:13 +0000
3+++ build.sh 2015-10-01 15:21:09 +0000
4@@ -9,14 +9,17 @@
5 arch=$1
6
7 case $arch in
8+ 386)
9+ plat_abi=i386-linux-gnu
10+ ;;
11 amd64)
12 plat_abi=x86_64-linux-gnu
13 ;;
14 arm)
15 plat_abi=arm-linux-gnueabihf
16 ;;
17- armhf)
18- plat_abi=arm-linux-gnueabihf
19+ arm64)
20+ plat_abi=aarch64-linux-gnu
21 ;;
22 *)
23 echo "unknown platform for snappy-magic: $arch remember to file a bug or better yet: fix it :)"
24@@ -28,13 +31,33 @@
25 }
26
27 gobuild() {
28- arch=$1
29-
30- plat_abi=$(get_platform_abi $arch)
31+ local arch=$1
32+ local plat_abi=$(get_platform_abi $arch)
33
34 mkdir -p "bin/$plat_abi"
35 cd "bin/$plat_abi"
36- GOARCH=$arch GOARM=7 CGO_ENABLED=1 CC=${plat_abi}-gcc go build -ldflags "-extld=${plat_abi}-gcc" launchpad.net/webdm/cmd/snappyd
37+
38+ local GOARCH CGO_ENABLED CC GO386 FLAGS
39+
40+ export GOARCH=$arch
41+ export CGO_ENABLED=1
42+
43+ if [ "$arch" = "386" ]; then
44+ # 386 is a special snowflake, etc
45+ # also, the edison doesn't have SSE, which we might care about
46+ export GO386=387
47+ else
48+ export CC=${plat_abi}-gcc
49+ if ! which $CC > /dev/null; then
50+ echo "Could not find $CC. Maybe you need to install gcc-${plat_abi}?"
51+ exit 1
52+ fi
53+
54+ FLAGS="-ldflags -extld=$CC"
55+ fi
56+
57+ go build $FLAGS launchpad.net/webdm/cmd/snappyd
58+
59 cd - > /dev/null
60 }
61
62@@ -55,11 +78,14 @@
63 cp -r www/public www/templates $builddir/www
64 cd $builddir
65
66-sed -i 's/\(architecture: \)UNKNOWN_ARCH/\1[amd64, armhf]/' \
67+sed -i 's/\(architectures: \)UNKNOWN_ARCH/\1[i386, amd64, armhf, arm64]/' \
68 $builddir/meta/package.yaml
69
70-gobuild arm
71-gobuild amd64
72+for arch in 386 amd64 arm arm64; do
73+ echo -n Building for $arch...
74+ gobuild $arch
75+ echo done
76+done
77
78 cd "$orig_pwd"
79
80
81=== modified file 'pkg/meta/package.yaml'
82--- pkg/meta/package.yaml 2015-10-01 15:21:09 +0000
83+++ pkg/meta/package.yaml 2015-10-01 15:21:09 +0000
84@@ -3,8 +3,8 @@
85 icon: meta/webdm-icon.png
86 source: lp:webdm
87 type: framework
88-version: 0.9.1
89-architecture: UNKNOWN_ARCH
90+version: 0.9.3
91+architectures: UNKNOWN_ARCH
92 services:
93 - name: snappyd
94 start: snappyd
95
96=== modified file 'pkg/snappyd'
97--- pkg/snappyd 2015-05-21 22:24:32 +0000
98+++ pkg/snappyd 2015-10-01 15:21:09 +0000
99@@ -4,6 +4,12 @@
100 platform=$(uname -i)
101
102 case $platform in
103+ i386)
104+ plat_abi=i386-linux-gnu
105+ ;;
106+ aarch64)
107+ plat_abi=aarch64-linux-gnu
108+ ;;
109 x86_64)
110 plat_abi=x86_64-linux-gnu
111 ;;
112@@ -15,7 +21,6 @@
113 ;;
114 esac
115
116-mkdir -m1777 -p $SNAP_APP_TMPDIR
117 exec $SNAP_APP_PATH/bin/$plat_abi/snappyd
118
119 # never reach this

Subscribers

People subscribed via source and target branches

to all changes: