Merge lp:~chipaca/snappy/remove-framework-aborts-on-dependent-snap into lp:~snappy-dev/snappy/snappy-moved-to-github

[John Lenton]

Check for dependents on framework remove.

[Michael Vogt (mvo)]

Thanks, this looks nice and straightforward. One minor naming suggestion inline, feel free to top-approve once resolved (either by renaming or keeping).

review: Approve

[lp:~chipaca/snappy/remove-framework-aborts-on-dependent-snap]

330. By John Lenton on 2015-04-09

renamed error as per mvo suggestion

=== modified file 'snappy/errors.go'
--- snappy/errors.go	2015-04-08 21:19:44 +0000
+++ snappy/errors.go	2015-04-09 13:16:52 +0000
@@ -179,3 +179,10 @@
 func (e ErrMissingFrameworks) Error() string {
 	return fmt.Sprintf("missing frameworks: %s", strings.Join(e, ", "))
 }
+
+// ErrFrameworkInUse reports that a framework is still needed by apps currently installed
+type ErrFrameworkInUse []string
+
+func (e ErrFrameworkInUse) Error() string {
+	return fmt.Sprintf("framework still in use by: %s", strings.Join(e, ", "))
+}

=== modified file 'snappy/snapp.go'
--- snappy/snapp.go	2015-04-08 21:19:44 +0000
+++ snappy/snapp.go	2015-04-09 13:16:52 +0000
@@ -399,6 +399,14 @@
 		return ErrPackageNotRemovable
 	}
 
+	deps, err := s.Dependents()
+	if err != nil {
+		return err
+	}
+	if len(deps) != 0 {
+		return ErrFrameworkInUse(deps)
+	}
+
 	return removeClick(s.basedir, pb)
 }
 
@@ -417,6 +425,38 @@
 	return s.m.Frameworks, nil
 }
 
+// Dependents gives the list of apps installed that depend on this one
+//
+// /!\ not part of the Part interface.
+func (s *SnapPart) Dependents() ([]string, error) {
+	if s.Type() != SnapTypeFramework {
+		// only frameworks are depended on
+		return nil, nil
+	}
+
+	var needed []string
+
+	installed, err := NewMetaRepository().Installed()
+	if err != nil {
+		return nil, err
+	}
+
+	name := s.Name()
+	for _, part := range installed {
+		fmks, err := part.Frameworks()
+		if err != nil {
+			return nil, err
+		}
+		for _, fmk := range fmks {
+			if fmk == name {
+				needed = append(needed, part.Name())
+			}
+		}
+	}
+
+	return needed, nil
+}
+
 // SnapLocalRepository is the type for a local snap repository
 type SnapLocalRepository struct {
 	path string

=== modified file 'snappy/snapp_test.go'
--- snappy/snapp_test.go	2015-04-09 08:57:40 +0000
+++ snappy/snapp_test.go	2015-04-09 13:16:52 +0000
@@ -781,3 +781,40 @@
 	err = yaml.checkForFrameworks()
 	c.Assert(err, ErrorMatches, `missing frameworks: missing, also-missing`)
 }
+
+func (s *SnapTestSuite) TestDetectsFrameworksInUse(c *C) {
+	_, err := makeInstalledMockSnap(s.tempdir, `name: foo
+version: 1.0
+frameworks:
+ - fmk
+`)
+	c.Assert(err, IsNil)
+
+	yaml, err := parsePackageYamlData([]byte(`name: fmk
+version: 1.0
+type: framework`))
+	c.Assert(err, IsNil)
+	part := &SnapPart{m: yaml}
+	deps, err := part.Dependents()
+	c.Assert(err, IsNil)
+	c.Check(deps, DeepEquals, []string{"foo"})
+}
+
+func (s *SnapTestSuite) TestRemoveChecksFrameworks(c *C) {
+	yamlFile, err := makeInstalledMockSnap(s.tempdir, `name: fmk
+version: 1.0
+type: framework`)
+	c.Assert(err, IsNil)
+	yaml, err := parsePackageYamlFile(yamlFile)
+
+	_, err = makeInstalledMockSnap(s.tempdir, `name: foo
+version: 1.0
+frameworks:
+ - fmk
+`)
+	c.Assert(err, IsNil)
+
+	part := &SnapPart{m: yaml}
+	err = part.Uninstall(new(MockProgressMeter))
+	c.Check(err, ErrorMatches, `framework still in use by: foo`)
+}