Merge lp:~chipaca/snappy/log-command-failure into lp:~snappy-dev/snappy/snappy-moved-to-github

[John Lenton]

Log command failures.

[Sergio Schvezov (sergiusens)]

Looks and feels like the right way to do it!

review: Approve

[Michael Vogt (mvo)]

Just one quick question, do we log each mistyped command this way?

On 8 May 2015 19:32:25 CEST, John Lenton <email address hidden> wrote:
>John Lenton has proposed merging lp:~chipaca/snappy/log-command-failure
>into lp:snappy with lp:~chipaca/snappy/no-more-log as a prerequisite.
>
>Commit message:
>Log command failures.
>
>Requested reviews:
> Snappy Developers (snappy-dev)
>
>For more details, see:
>https://code.launchpad.net/~chipaca/snappy/log-command-failure/+merge/258669
>--
>Your team Snappy Developers is requested to review the proposed merge
>of lp:~chipaca/snappy/log-command-failure into lp:snappy.

--
Sent from my Android phone with K-9 Mail. Please excuse my brevity.

[John Lenton (chipaca)]

May 8 20:45:05 fogey ./snappy-go_amd64[13993]: main.go:59: DEBUG: [./snappy-go_amd64] failed: Please specify one command of: booted, build, config, firstboot, hw-assign, hw-info, hw-unassign, info, install, internal-run-hooks, internal-unpack, list, login, purge, remove, rollback, search, set, update or versions
May 8 20:45:21 fogey ./snappy-go_amd64[14000]: main.go:59: DEBUG: [./snappy-go_amd64 eppfov] failed: Unknown command `eppfov'. Please specify one command of: booted, build, config, firstboot, hw-assign, hw-info, hw-unassign, info, install, internal-run-hooks, internal-unpack, list, login, purge, remove, rollback, search, set, update or versions
May 8 20:45:31 fogey ./snappy-go_amd64[14014]: main.go:59: DEBUG: [./snappy-go_amd64 list --eppfov] failed: unknown flag `eppfov'
May 8 20:45:41 fogey ./snappy-go_amd64[14019]: main.go:59: DEBUG: [./snappy-go_amd64 install --rprworqe] failed: unknown flag `rprworqe'
May 8 20:45:47 fogey ./snappy-go_amd64[14023]: main.go:59: DEBUG: [./snappy-go_amd64 install weprpq] failed: this command requires root access. Please re-run using 'sudo'

So, before, yes.

But not now.

[Michael Vogt (mvo)]

Thanks and sorry for being difficult - I presume we also log "snappy install typo" type failures still? Might be a ok trade-off for the simplicity of the approach though :)

[John Lenton (chipaca)]

Yes, those would still get logged.

As you say, keeps things simple.

[Sergio Schvezov (sergiusens)]

review: Approve

[Snappy Tarmac (snappydevtarmac)]

There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions.

[Sergio Schvezov (sergiusens)]

review: Approve

=== modified file 'cmd/snappy/main.go'
--- cmd/snappy/main.go	2015-05-18 19:15:50 +0000
+++ cmd/snappy/main.go	2015-05-18 19:15:50 +0000
@@ -55,6 +55,10 @@
 			// the CLI user.
 			err = snappy.ErrNeedRoot
 		}
+		if _, ok := err.(*flags.Error); !ok {
+			// Debug, because the parser will print the error for us
+			logger.Debugf("%v failed: %v", os.Args, err)
+		}
 		os.Exit(1)
 	}
 }