Merge lp:~chipaca/libubuntuone/fix-863176 into lp:libubuntuone

Proposed by John Lenton
Status: Merged
Approved by: dobey
Approved revision: 138
Merged at revision: 138
Proposed branch: lp:~chipaca/libubuntuone/fix-863176
Merge into: lp:libubuntuone
Diff against target: 26 lines (+4/-2)
1 file modified
libubuntuone/u1-music-store.c (+4/-2)
To merge this branch: bzr merge lp:~chipaca/libubuntuone/fix-863176
Reviewer Review Type Date Requested Status
dobey (community) Approve
Stuart Langridge (community) Approve
Review via email: mp+77688@code.launchpad.net

Commit message

Escape the url passed in to forward_on_to_url

Description of the change

quote the url passed in to forward_on_to_url, so u1ms links to the world store work.

To post a comment you must log in.
Revision history for this message
Stuart Langridge (sil) wrote :

Works when manually applying the changes to natty and recompiling.

review: Approve
Revision history for this message
dobey (dobey) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'libubuntuone/u1-music-store.c'
2--- libubuntuone/u1-music-store.c 2011-09-09 15:11:47 +0000
3+++ libubuntuone/u1-music-store.c 2011-09-30 11:18:34 +0000
4@@ -1425,7 +1425,7 @@
5 void
6 u1_music_store_load_store_link (U1MusicStore *music_store, const gchar *url)
7 {
8- gchar *real_url, *oauth_consumer_token, *oauth_consumer_secret, *oauth_token, *oauth_token_secret;
9+ gchar *real_url, *oauth_consumer_token, *oauth_consumer_secret, *oauth_token, *oauth_token_secret, *quoted_url;
10
11 g_return_if_fail (U1_IS_MUSIC_STORE (music_store));
12 g_return_if_fail (url != NULL);
13@@ -1436,10 +1436,12 @@
14 music_store->priv->idle_cb = 0;
15 }
16
17+ quoted_url = g_uri_escape_string (url, NULL, FALSE);
18 real_url = g_strdup_printf ("%s%s?forward_on_to_url=%s",
19 music_store->priv->base_url,
20 U1_STORE_URL,
21- url);
22+ quoted_url);
23+ g_free (quoted_url);
24
25 /* Sign the URL if we have OAuth tokens */
26 get_credentials (music_store,

Subscribers

People subscribed via source and target branches