Merge lp:~chipaca/gsettings-ubuntu-touch-schemas/fix-notification-hub-blacklist-description into lp:gsettings-ubuntu-touch-schemas

Proposed by John Lenton
Status: Approved
Approved by: Sebastien Bacher
Approved revision: 51
Proposed branch: lp:~chipaca/gsettings-ubuntu-touch-schemas/fix-notification-hub-blacklist-description
Merge into: lp:gsettings-ubuntu-touch-schemas
Diff against target: 15 lines (+3/-2)
1 file modified
schemas/com.ubuntu.notifications.hub.gschema.xml.in.in (+3/-2)
To merge this branch: bzr merge lp:~chipaca/gsettings-ubuntu-touch-schemas/fix-notification-hub-blacklist-description
Reviewer Review Type Date Requested Status
Sebastien Bacher (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+238417@code.launchpad.net

Commit message

Fixed description for notifications blacklist.

Description of the change

There was an error in the description of the blacklist, which stated that a dpkg-installed app would be listed as (appname, appname) -- that's an error because it's very easy to get an appname that is also a valid click package id; what it should've said is that dpkg apps were listed as ("", appname).

Fixed that.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Sebastien Bacher (seb128) wrote :

thanks, one nitpick though, the bug example shows the value doesn't include the '.desktop', should it be documented as "basename" rather than "filename" then?

review: Needs Information
51. By John Lenton

clarify the desktop filename more

Revision history for this message
Sebastien Bacher (seb128) wrote :

thanks

review: Approve

Unmerged revisions

51. By John Lenton

clarify the desktop filename more

50. By John Lenton

Fixed an error in the description of the blacklist entries for legacy apps.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'schemas/com.ubuntu.notifications.hub.gschema.xml.in.in'
2--- schemas/com.ubuntu.notifications.hub.gschema.xml.in.in 2014-08-01 23:11:07 +0000
3+++ schemas/com.ubuntu.notifications.hub.gschema.xml.in.in 2014-10-15 13:17:53 +0000
4@@ -7,8 +7,9 @@
5 A list of applications that the user has blocked notifications from.
6 For applications that are installed via Click packaging the strings are
7 the name of the package and then the name of the application in the
8- package. For dpkg based applications the strings are both the
9- AppID of the application, or the desktop file name.
10+ package. For dpkg based applications the first string is empty and the
11+ second one is the AppID of the application (the desktop file basename
12+ without the .desktop extension).
13 </_description>
14 </key>
15 </schema>

Subscribers

People subscribed via source and target branches