Merge lp:~chipaca/gsettings-ubuntu-touch-schemas/fix-notification-hub-blacklist-description into lp:gsettings-ubuntu-touch-schemas
Proposed by
John Lenton
Status: | Approved |
---|---|
Approved by: | Sebastien Bacher |
Approved revision: | 51 |
Proposed branch: | lp:~chipaca/gsettings-ubuntu-touch-schemas/fix-notification-hub-blacklist-description |
Merge into: | lp:gsettings-ubuntu-touch-schemas |
Diff against target: |
15 lines (+3/-2) 1 file modified
schemas/com.ubuntu.notifications.hub.gschema.xml.in.in (+3/-2) |
To merge this branch: | bzr merge lp:~chipaca/gsettings-ubuntu-touch-schemas/fix-notification-hub-blacklist-description |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Sebastien Bacher (community) | Approve | ||
PS Jenkins bot | continuous-integration | Needs Fixing | |
Review via email: mp+238417@code.launchpad.net |
Commit message
Fixed description for notifications blacklist.
Description of the change
There was an error in the description of the blacklist, which stated that a dpkg-installed app would be listed as (appname, appname) -- that's an error because it's very easy to get an appname that is also a valid click package id; what it should've said is that dpkg apps were listed as ("", appname).
Fixed that.
To post a comment you must log in.
Unmerged revisions
- 51. By John Lenton
-
clarify the desktop filename more
- 50. By John Lenton
-
Fixed an error in the description of the blacklist entries for legacy apps.
FAILED: Continuous integration, rev:50 /code.launchpad .net/~chipaca/ gsettings- ubuntu- touch-schemas/ fix-notificatio n-hub-blacklist -description/ +merge/ 238417/ +edit-commit- message
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https:/
http:// jenkins. qa.ubuntu. com/job/ gsettings- ubuntu- touch-schemas- ci/43/ jenkins. qa.ubuntu. com/job/ gsettings- ubuntu- touch-schemas- utopic- amd64-ci/ 23 jenkins. qa.ubuntu. com/job/ gsettings- ubuntu- touch-schemas- utopic- armhf-ci/ 23 jenkins. qa.ubuntu. com/job/ gsettings- ubuntu- touch-schemas- utopic- i386-ci/ 23
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/gsettings- ubuntu- touch-schemas- ci/43/rebuild
http://