Merge lp:~chipaca/apt/filedir-no-glob into lp:~deity/apt/old-debian-sid

Proposed by John Lenton
Status: Needs review
Proposed branch: lp:~chipaca/apt/filedir-no-glob
Merge into: lp:~deity/apt/old-debian-sid
Diff against target: 12 lines (+1/-1)
1 file modified
completions/bash/apt (+1/-1)
To merge this branch: bzr merge lp:~chipaca/apt/filedir-no-glob
Reviewer Review Type Date Requested Status
Julian Andres Klode Disapprove
Review via email: mp+312075@code.launchpad.net

Description of the change

use _filedir with an extension, not a glob. Using `_filedir "*.deb"` means only files that match `*.*.deb` get tab-completed.

To post a comment you must log in.
Revision history for this message
Julian Andres Klode (juliank) wrote :

Please submit fixes via git, either as email, a branch, or pull request on github.


bzr is not used anymore for development.

review: Disapprove
Revision history for this message
John Lenton (chipaca) wrote :

Please put a note to that effect on lp:apt?

Unmerged revisions

3555. By John Lenton

fixes lp:1645815

3554. By John Lenton

_filedir takes an extension, not a glob

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'completions/bash/apt'
2--- completions/bash/apt 2016-05-13 09:01:40 +0000
3+++ completions/bash/apt 2016-11-29 18:03:43 +0000
4@@ -189,7 +189,7 @@
5 install)
6 COMPREPLY=( $( apt-cache --no-generate pkgnames "$cur" \
7 2> /dev/null ) )
8- _filedir "*.deb"
9+ _filedir "deb"
10 return 0
11 ;;
12 source|build-dep|showsrc|policy)


People subscribed via source and target branches