Merge lp:~chihchun/ubuntu-touch-session/lp1582148 into lp:ubuntu-touch-session

Proposed by Rex Tsai
Status: Merged
Approved by: Rex Tsai
Approved revision: 286
Merged at revision: 285
Proposed branch: lp:~chihchun/ubuntu-touch-session/lp1582148
Merge into: lp:ubuntu-touch-session
Diff against target: 91 lines (+4/-58)
4 files modified
upstart-session/cameraservice-trust-stored.conf (+2/-2)
upstart-session/cameraservice-trust-stored.conf.moved (+0/-33)
upstart-session/pulseaudio-trust-stored.conf (+2/-2)
upstart-session/pulseaudio-trust-stored.conf.moved (+0/-21)
To merge this branch: bzr merge lp:~chihchun/ubuntu-touch-session/lp1582148
Reviewer Review Type Date Requested Status
Thomas Voß Pending
Ubuntu Phablet Team Pending
Review via email: mp+299551@code.launchpad.net

Commit message

Reload trust-stored, when use switched locale in the welcome wizard.

Description of the change

When the user change locale in Welcome Wizard, unity8 sends indicator-services-end and indicator-services-start to ask other service eg indicator-services reloaded for the new locale.

https://bugs.launchpad.net/bugs/1582148

To post a comment you must log in.
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

This MP still needs top-approval, the ticket is stuck: https://requests.ci-train.ubuntu.com/#/ticket/1652

Revision history for this message
Rex Tsai (chihchun) wrote :

The patch should be clean enough to be landed.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'upstart-session/cameraservice-trust-stored.conf'
2--- upstart-session/cameraservice-trust-stored.conf 2015-08-25 12:33:04 +0000
3+++ upstart-session/cameraservice-trust-stored.conf 2016-07-08 13:58:12 +0000
4@@ -1,7 +1,7 @@
5 description "CameraService Trust Store Daemon"
6
7-start on started dbus and xsession SESSION=ubuntu-touch
8-stop on runlevel [06]
9+start on (started dbus and xsession SESSION=ubuntu-touch) or indicator-services-start
10+stop on (runlevel [06]) or indicator-services-end
11
12 respawn
13
14
15=== removed file 'upstart-session/cameraservice-trust-stored.conf.moved'
16--- upstart-session/cameraservice-trust-stored.conf.moved 2016-01-14 12:31:52 +0000
17+++ upstart-session/cameraservice-trust-stored.conf.moved 1970-01-01 00:00:00 +0000
18@@ -1,33 +0,0 @@
19-description "CameraService Trust Store Daemon"
20-
21-start on started dbus and xsession SESSION=ubuntu-touch
22-stop on runlevel [06]
23-
24-respawn
25-
26-script
27- timeout=800
28- service_socket=/dev/socket/camera_service/camera_service_to_trust
29- # loop and then exit, if camera service isnt up after 80 sec
30- # it is likely not starting at all (or not there)
31- while [ ! -e $service_socket ]; do
32- sleep 0.1
33- if [ "$timeout" -le 0 ]; then
34- stop; exit 0
35- fi
36- timeout=$(($timeout - 1))
37- done
38-
39- # Extra security to make sure the service is bound to the sockec
40- # TODO check if needed by inspection of trust store library / camera service
41- sleep 1
42-
43- exec /usr/bin/trust-stored-skeleton \
44- --remote-agent UnixDomainSocketRemoteAgent --endpoint=$service_socket \
45- --local-agent MirAgent \
46- --trusted-mir-socket=/var/run/user/$(id -u)/mir_socket_trusted \
47- --for-service CameraService \
48- --with-text-domain CameraService \
49- --store-bus session \
50- --disable-whitelisting=yes
51-end script
52
53=== modified file 'upstart-session/pulseaudio-trust-stored.conf'
54--- upstart-session/pulseaudio-trust-stored.conf 2015-08-25 12:45:50 +0000
55+++ upstart-session/pulseaudio-trust-stored.conf 2016-07-08 13:58:12 +0000
56@@ -1,7 +1,7 @@
57 description "Pulseaudio Trust Store Daemon"
58
59-start on started pulseaudio
60-stop on stopped pulseaudio
61+start on started pulseaudio or indicator-services-start
62+stop on stopped pulseaudio or indicator-services-end
63
64 respawn
65
66
67=== removed file 'upstart-session/pulseaudio-trust-stored.conf.moved'
68--- upstart-session/pulseaudio-trust-stored.conf.moved 2016-01-14 12:31:52 +0000
69+++ upstart-session/pulseaudio-trust-stored.conf.moved 1970-01-01 00:00:00 +0000
70@@ -1,21 +0,0 @@
71-description "Pulseaudio Trust Store Daemon"
72-
73-start on started pulseaudio
74-stop on stopped pulseaudio
75-
76-respawn
77-
78-script
79- # Extra security until trust-stored handles DBus name owner changes
80- # for the service
81- sleep 2
82-
83- exec /usr/bin/trust-stored-skeleton \
84- --remote-agent DBusRemoteAgent --bus=session \
85- --local-agent MirAgent \
86- --trusted-mir-socket=/var/run/user/$(id -u)/mir_socket_trusted \
87- --for-service PulseAudio \
88- --with-text-domain PulseAudio \
89- --store-bus session \
90- --disable-whitelisting=yes
91-end script

Subscribers

People subscribed via source and target branches