Merge lp:~chihchun/phablet-tools/phablet-tools-lp1221689 into lp:phablet-tools

Proposed by Rex Tsai on 2013-09-06
Status: Rejected
Rejected by: Sergio Schvezov on 2013-10-29
Proposed branch: lp:~chihchun/phablet-tools/phablet-tools-lp1221689
Merge into: lp:phablet-tools
Diff against target: 30 lines (+9/-0)
2 files modified
phabletutils/arguments.py (+5/-0)
phabletutils/environment.py (+4/-0)
To merge this branch: bzr merge lp:~chihchun/phablet-tools/phablet-tools-lp1221689
Reviewer Review Type Date Requested Status
Sergio Schvezov 2013-09-06 Disapprove on 2013-09-06
PS Jenkins bot continuous-integration Needs Fixing on 2013-09-06
Review via email: mp+184276@code.launchpad.net

Description of the change

* Bug #1221689 “Please make alternate download uri works again” : Bugs : “phablet-tools” package : Ubuntu https://bugs.launchpad.net/bugs/1221689

To post a comment you must log in.
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:182
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~chihchun/phablet-tools/phablet-tools-lp1221689/+merge/184276/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/phablet-tools-ci/155/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-saucy-amd64-ci/98
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-saucy-armhf-ci/98
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-saucy-i386-ci/98

Click here to trigger a rebuild:
http://s-jenkins:8080/job/phablet-tools-ci/155/rebuild

review: Needs Fixing (continuous-integration)
Sergio Schvezov (sergiusens) wrote :

You should add this to ufa flash if at all, this is not commonly supported anymore on cdimage

Check
https://code.launchpad.net/~sergiusens/cambridge/ufa-flash/+merge/183533

review: Disapprove
Rex Tsai (chihchun) wrote :

Well, I use this option for downlaod and reflashing some old ubuntu touch images, not for ufa.

Unmerged revisions

182. By Rex Tsai on 2013-09-06

make alternate download uri works again.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'phabletutils/arguments.py'
2--- phabletutils/arguments.py 2013-08-29 18:10:40 +0000
3+++ phabletutils/arguments.py 2013-09-06 11:38:08 +0000
4@@ -217,6 +217,11 @@
5
6 def common_supported():
7 parser = argparse.ArgumentParser(add_help=False)
8+ parser.add_argument('-u',
9+ '--uri',
10+ required=False,
11+ help='Alternate download uri')
12+
13 parser.add_argument('-d',
14 '--device',
15 help='''Target device to deploy.''',
16
17=== modified file 'phabletutils/environment.py'
18--- phabletutils/environment.py 2013-09-06 05:33:58 +0000
19+++ phabletutils/environment.py 2013-09-06 11:38:08 +0000
20@@ -109,6 +109,10 @@
21 device = detect_device(args.serial, args.device)
22 if args.base_path:
23 download_dir = args.base_path
24+ elif args.uri:
25+ uri = args.uri
26+ build = downloads.get_ubuntu_stamp(uri)
27+ download_dir = downloads.get_full_path(os.path.join(settings.download_dir, build))
28 elif args.revision or args.latest_revision:
29 build = args.build
30 uri = args.uri

Subscribers

People subscribed via source and target branches