plainbox-provider-checkbox:phlin/code-style-fix

Branch merges

Propose for merging

Merged into plainbox-provider-checkbox:master at revision 4c7a9c3bf9e2c88b5f5ef85524ac25b2c5ce5db2

Maciej Kisielewski: Approve on 2021-08-27

Jonathan Cave: Pending requested 2021-08-26

Diff: 96 lines (+17/-23)

1 file modified

bin/kernel_taint_test.py (+17/-23)

api

Superseded for merging into plainbox-provider-checkbox:master

Jonathan Cave: Pending requested 2021-07-28

Checkbox Developers: Pending requested 2021-07-21

Diff: 96 lines (+17/-23)

1 file modified

bin/kernel_taint_test.py (+17/-23)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

f429d2a... by Po-Hsu Lin on 2021-07-21

Change: bin/kernel_taint_test.py: move report_failures() to main() and code cleanup

The report_failures() is now just return whether the test pass or fail
move the code piece to main() and update the docstring accordingly.

The tainted bit value and its message will be printed at the beginning
of this if statement, there is no need to print it again.

Remove unnecessary parentheses for return

Use raise SystemExit() for taint_file not found exeception.

0fb3f4c... by PMR <pmr@pmr-lander> on 2021-07-21

Merge #405897 from plainbox-provider-checkbox:phlin/fix-tainted-check

exit takes only integer args in the range 0 - 255
If we return the taint value read from /proc/sys/kernel/tainted,
it might exceed this range and causing unexpected behaviour.

e.g. on a system with kernel warning
$ ./kernel_taint_test.py
Kernel taint value is 512
Taint bit value: 9 (kernel issued warning)
Taint bit value: 9 (kernel issued warning)
$ echo $?
0

Let's just simplify the return logic of report_failures() to return
either 0 or 1.

11f1532... by Po-Hsu Lin on 2021-07-19

bin/kernel_taint_test.py: return 0 for passed cases, 1 for others

exit takes only integer args in the range 0 - 255
If we return the taint value read from /proc/sys/kernel/tainted,
it might exceed this range and causing unexpected behaviour.

e.g. on a system with kernel warning
$ ./kernel_taint_test.py
Kernel taint value is 512
Taint bit value: 9 (kernel issued warning)
Taint bit value: 9 (kernel issued warning)
$ echo $?
0

Let's just simplify the return logic of report_failures() to return
either 0 or 1.

Signed-off-by: Po-Hsu Lin <email address hidden>

d82e5c2... by PMR <pmr@pmr-lander> on 2021-07-15

Merge #405172 from ~zongminl/plainbox-provider-checkbox:sync-watchdog-test-between-classic-and-core

Change: Align the test for watchdog config on classic and core image

Watchdog implementation on both classic and core image no longer rely
on watchdogd service since 20.04, with this change watchdog/systemd-config
tests only systemd configuration on 20.04 and later series while keeping
the original test for prior releases

a610500... by Vic Liu on 2021-07-02

Change: Align the test for watchdog config on classic and core image

Watchdog implementation on both classic and core image no longer rely
on watchdogd service since 20.04, with this change watchdog/systemd-config
tests only systemd configuration on 20.04 and later series while keeping
the original test for prior releases

6689ffb... by PMR <pmr@pmr-lander> on 2021-07-15

Merge #405682 from ~kchsieh/plainbox-provider-checkbox/+git/plainbox-provider-checkbox:iwlwifi-microcode-crash

Add: iwlwifi microcode crash check

db7032c... by Kai-Chuan Hsieh on 2021-07-14

Add: iwlwifi microcode crash check

LP: #1932548

46d262b... by PMR <pmr@pmr-lander> on 2021-07-12

Merge #405578 from plainbox-provider-checkbox:release

Release_2021_Week28

6ff546a... by PMR <pmr@pmr-lander> on 2021-07-12

increment version to v0.60.0.dev0

f27a50c... by PMR <pmr@pmr-lander> on 2021-07-12

Bump to v0.59.0