Merge lp:~chasedouglas/grail/fix-tap-touch-accept into lp:grail

Proposed by Chase Douglas
Status: Merged
Approved by: Daniel d'Andrada
Approved revision: 209
Merged at revision: 202
Proposed branch: lp:~chasedouglas/grail/fix-tap-touch-accept
Merge into: lp:grail
Prerequisite: lp:~chasedouglas/grail/tap-touch-accept-test
Diff against target: 0 lines
To merge this branch: bzr merge lp:~chasedouglas/grail/fix-tap-touch-accept
Reviewer Review Type Date Requested Status
Daniel d'Andrada (community) Approve
Review via email: mp+98478@code.launchpad.net

Description of the change

Fix bug 960438: tap touches rejected erroneously.

To post a comment you must log in.
210. By Chase Douglas

Remove threaded recording playback

Valgrind doesn't work well with multithreaded processes, and the threaded
playback isn't really necessary.

211. By Chase Douglas

Filter out all touch events sent to the subwindow

Unfiltered events are sent to utouch-frame for processing. We filter out
begin events sent to the subwindow, so we need to filter out all other
touch events too. Frame gets confused if it starts seeing update and end
events for touches that have not begun.

212. By Chase Douglas

Allow extra slack time in Timeout test due to synchronous event playback

213. By Chase Douglas

Remove includes of C++11 future module

They are no longer needed.

214. By Chase Douglas

Clean up subscriptions at the end of tests

Now, all grail v3 tests run without any memory leaks or corruption except
for three leaks in Xlib.

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

Looks ok but I think it needs to have a comment somewhere explaining *why* it's important to accept a touch that has already ended (the story that the touch sequence will be sent to another client further down the window tree/hierarchy if rejected).

review: Approve
215. By Chase Douglas

Merged utouch-grail into tap-touch-accept-test.

216. By Chase Douglas

Rename recording variable, "bad_drag" was a copy&paste error

217. By Chase Douglas

Remove unused DRAG_TIMEOUT, copy&paste error

Preview Diff

Empty

Subscribers

People subscribed via source and target branches