Merge lp:~chasedouglas/geis/fix-geisv1-class-ids into lp:geis

Proposed by Chase Douglas on 2012-09-07
Status: Merged
Merged at revision: 286
Proposed branch: lp:~chasedouglas/geis/fix-geisv1-class-ids
Merge into: lp:geis
Diff against target: 31 lines (+5/-5)
1 file modified
libgeis/backend/grail/geis_grail_backend.c (+5/-5)
To merge this branch: bzr merge lp:~chasedouglas/geis/fix-geisv1-class-ids
Reviewer Review Type Date Requested Status
Stephen M. Webb (community) Approve on 2012-09-07
Chase Douglas (community) Approve on 2012-09-07
Review via email: mp+123354@code.launchpad.net

Description of the Change

The Geisv1 gesture IDs were changed when the old grail architecture was removed, since the IDs were based on grail v2 constants. Unfortunately, the gesture IDs are part of the v1 ABI. The change causes all geisv1 clients to fail to work.

This merge proposal resets the gesture ID values to match what is in the public header.

To post a comment you must log in.
286. By Chase Douglas on 2012-09-07

Revert the gesture class IDs to their original values

This broke Geisv1 clients, where the values are part of the ABI.

Chase Douglas (chasedouglas) wrote :

Due to the timing of things, I'm just going to unilaterally push this through. I believe this is the correct solution to the issue.

review: Approve
Stephen M. Webb (bregma) wrote :

Maps grail gesture types to public geis gesture types. Existing clients should remain unaffected.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'libgeis/backend/grail/geis_grail_backend.c'
2--- libgeis/backend/grail/geis_grail_backend.c 2012-09-05 18:37:28 +0000
3+++ libgeis/backend/grail/geis_grail_backend.c 2012-09-07 20:21:18 +0000
4@@ -1325,23 +1325,23 @@
5 / sizeof(struct GeisFilterableAttribute);
6
7 gbe->drag_class = geis_gesture_class_new(GEIS_GESTURE_DRAG,
8- UGGestureTypeDrag);
9+ GEIS_GESTURE_PRIMITIVE_DRAG);
10 geis_register_gesture_class(gbe->geis, gbe->drag_class, attr_count, attrs);
11
12 gbe->pinch_class = geis_gesture_class_new(GEIS_GESTURE_PINCH,
13- UGGestureTypePinch);
14+ GEIS_GESTURE_PRIMITIVE_PINCH);
15 geis_register_gesture_class(gbe->geis, gbe->pinch_class, attr_count, attrs);
16
17 gbe->rotate_class = geis_gesture_class_new(GEIS_GESTURE_ROTATE,
18- UGGestureTypeRotate);
19+ GEIS_GESTURE_PRIMITIVE_ROTATE);
20 geis_register_gesture_class(gbe->geis, gbe->rotate_class, attr_count, attrs);
21
22 gbe->tap_class = geis_gesture_class_new(GEIS_GESTURE_TAP,
23- UGGestureTypeTap);
24+ GEIS_GESTURE_PRIMITIVE_TAP);
25 geis_register_gesture_class(gbe->geis, gbe->tap_class, attr_count, attrs);
26
27 gbe->touch_class = geis_gesture_class_new(GEIS_GESTURE_TOUCH,
28- UGGestureTypeTouch);
29+ GEIS_GESTURE_PRIMITIVE_TOUCH);
30 geis_register_gesture_class(gbe->geis, gbe->touch_class, attr_count, attrs);
31 }
32

Subscribers

People subscribed via source and target branches