Merge lp:~chasedouglas/geis/fix-geisv1-class-ids into lp:geis
Proposed by
Chase Douglas
on 2012-09-07
| Status: | Merged |
|---|---|
| Merged at revision: | 286 |
| Proposed branch: | lp:~chasedouglas/geis/fix-geisv1-class-ids |
| Merge into: | lp:geis |
| Diff against target: |
31 lines (+5/-5) 1 file modified
libgeis/backend/grail/geis_grail_backend.c (+5/-5) |
| To merge this branch: | bzr merge lp:~chasedouglas/geis/fix-geisv1-class-ids |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Stephen M. Webb (community) | Approve on 2012-09-07 | ||
| Chase Douglas (community) | Approve on 2012-09-07 | ||
|
Review via email:
|
|||
Description of the Change
The Geisv1 gesture IDs were changed when the old grail architecture was removed, since the IDs were based on grail v2 constants. Unfortunately, the gesture IDs are part of the v1 ABI. The change causes all geisv1 clients to fail to work.
This merge proposal resets the gesture ID values to match what is in the public header.
To post a comment you must log in.
lp:~chasedouglas/geis/fix-geisv1-class-ids
updated
on 2012-09-07
- 286. By Chase Douglas on 2012-09-07
-
Revert the gesture class IDs to their original values
This broke Geisv1 clients, where the values are part of the ABI.
| Stephen M. Webb (bregma) wrote : | # |
Maps grail gesture types to public geis gesture types. Existing clients should remain unaffected.
review:
Approve


Due to the timing of things, I'm just going to unilaterally push this through. I believe this is the correct solution to the issue.