Merge lp:~charlesk/unity8/lp-1410915-re-enable-rotation-lock-test into lp:unity8

[Charles Kerr]

Re-enable a rotation lock test now that the bug that broke that test has been fixed.

== Change Description

Re-enable a rotation lock test now that the bug that broke that test has been fixed.

== Checklist

> Are there any related MPs required for this MP to build/function as expected? Please list.

https://code.launchpad.net/~charlesk/indicator-display/lp-1410915-fix-action-state-to-gsettings-mapping/+merge/251377

> Did you perform an exploratory manual test run of your code change and any related functionality?

Yes; "autopilot3 run unity8.indicators.tests.test_display_indicator" passed

> Did you make sure that your branch does not contain spurious tags?

No tag changes

> If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?

N/A

> If you changed the UI, has there been a design review?

N/A

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1641
http://jenkins.qa.ubuntu.com/job/unity8-ci/5373/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1591/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/537
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/538
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/538
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/1412/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1589
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1589/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/18451

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/5373/rebuild

review: Needs Fixing (continuous-integration)

[Charles Kerr (charlesk)]

Jenkins shouldn't be happy with this until the above-mentioned indicator-display fix lands.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1641
http://jenkins.qa.ubuntu.com/job/unity8-ci/5378/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1609
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/542
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/543
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/543
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/1428
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1607
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1607/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/18484

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/5378/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1641
http://jenkins.qa.ubuntu.com/job/unity8-ci/5391/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1660
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/555
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/556
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/556
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/1473
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1658
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1658/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/18577

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/5391/rebuild

review: Needs Fixing (continuous-integration)

[Albert Astals Cid (aacid)]

Please run http://people.canonical.com/~msawicz/unity8/strip-u8-tags.py on this branch

review: Needs Fixing

[Leo Arias (elopio)]

review: Approve

[lp:~charlesk/unity8/lp-1410915-re-enable-rotation-lock-test]

1642. By Charles Kerr on 2015-03-11

strip tags with strip-u8-tags.py

[Albert Astals Cid (aacid)]

 * Did you perform an exploratory manual test run of the code change and any related functionality?
No, it's test only

 * Did CI run pass?
No, but the changed one works

 * Did you make sure that the branch does not contain spurious tags?
Yes

review: Approve

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1642
http://jenkins.qa.ubuntu.com/job/unity8-ci/5416/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1726
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/580
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/581
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/581
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/1532
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1724
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1724/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/18760

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/5416/rebuild

review: Needs Fixing (continuous-integration)

=== modified file 'tests/autopilot/unity8/indicators/tests/test_display_indicator.py'
--- tests/autopilot/unity8/indicators/tests/test_display_indicator.py	2015-01-21 04:01:57 +0000
+++ tests/autopilot/unity8/indicators/tests/test_display_indicator.py	2015-03-11 14:10:29 +0000
@@ -26,9 +26,6 @@
 class DisplayIndicatorTestCase(tests.IndicatorTestCase):
 
     def test_indicator_icon_must_be_visible_after_rotation_locked(self):
-        # TODO remove the skip when the bug is fixed. --elopio - 2015-01-20
-        self.skipTest(
-            'This test fails because of bug http://pad.lv/1410915')
         rotation_unlocked = fixture_setup.DisplayRotationLock(False)
         self.useFixture(rotation_unlocked)
         display_indicator = indicators.DisplayIndicator(self.main_window)