Merge lp:~charlesk/ubuntuone-client/lp-981255 into lp:ubuntuone-client

Proposed by Charles Kerr on 2012-04-13
Status: Merged
Approved by: dobey on 2012-04-16
Approved revision: 1224
Merged at revision: 1224
Proposed branch: lp:~charlesk/ubuntuone-client/lp-981255
Merge into: lp:ubuntuone-client
Diff against target: 11 lines (+1/-0)
1 file modified
libsyncdaemon/syncdaemon-daemon.c (+1/-0)
To merge this branch: bzr merge lp:~charlesk/ubuntuone-client/lp-981255
Reviewer Review Type Date Requested Status
dobey (community) 2012-04-16 Approve on 2012-04-16
Manuel de la Peña (community) 2012-04-13 Approve on 2012-04-16
Review via email:

Commit message

Fix dirpath leak in syncdaemon_daemon_is_folder_enabled()

Description of the change

Simple one-liner to plug a leak.

To post a comment you must log in.
Manuel de la Peña (mandel) wrote :

Looks good to me since it might be the case that the g_strcmp0 is not 0 and we do not longer use dirpath.

review: Approve
dobey (dobey) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'libsyncdaemon/syncdaemon-daemon.c'
2--- libsyncdaemon/syncdaemon-daemon.c 2012-04-09 20:07:05 +0000
3+++ libsyncdaemon/syncdaemon-daemon.c 2012-04-13 23:40:23 +0000
4@@ -963,6 +963,7 @@
5 g_free (dirpath);
6 return FALSE;
7 }
8+ g_free (dirpath);
10 /* And finally check UDFs */
11 interface = syncdaemon_daemon_get_folders_interface (daemon);


People subscribed via source and target branches