Ubuntu Clock App

Merge lp:~charlesk/ubuntu-clock-app/lp-1275560 into lp:ubuntu-clock-app/saucy

  1. lp-1275560
  2. Merge into saucy
Proposed by Charles Kerr
Status: Rejected
Rejected by: David Planella
Proposed branch: lp:~charlesk/ubuntu-clock-app/lp-1275560
Merge into: lp:ubuntu-clock-app/saucy
Diff against target: 12 lines (+1/-1)
1 file modified
alarm/AddAlarmPage.qml (+1/-1)
To merge this branch: bzr merge lp:~charlesk/ubuntu-clock-app/lp-1275560
Reviewer Review Type Date Requested Status
David Planella Disapprove
Nekhelesh Ramananthan Pending
Review via email: mp+208217@code.launchpad.net

Commit message

Fix AddAlarmPage.setMinuteLabel()'s bounds checking

Description of the change

Fix AddAlarmPage.setMinuteLabel()'s bounds checking

To post a comment you must log in.
Revision history for this message
David Planella (dpm) wrote :

Marking as Rejected while cleaning up core apps branches. The bug was resolved a while ago.

review: Disapprove

Unmerged revisions

352. By Charles Kerr

fix the code in AddAlarmPage.setMinuteLabel() that limits the minutes' upper bound to 59.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'alarm/AddAlarmPage.qml'
2--- alarm/AddAlarmPage.qml 2014-02-20 22:31:32 +0000
3+++ alarm/AddAlarmPage.qml 2014-02-25 19:49:53 +0000
4@@ -193,7 +193,7 @@
5
6 // Function to print minute label
7 function setMinutesLabel(minutes) {
8- if (addAlarmFace.minutes > 59) {
9+ if (minutes > 59) {
10 minutes = 0
11 }
12 addAlarmFace.minutes = Math.round(minutes)

Subscribers

People subscribed via source and target branches