Merge lp:~charlesk/overlay-scrollbar/lp-1058205 into lp:overlay-scrollbar
Proposed by
Charles Kerr
Status: | Merged |
---|---|
Merged at revision: | 357 |
Proposed branch: | lp:~charlesk/overlay-scrollbar/lp-1058205 |
Merge into: | lp:overlay-scrollbar |
Diff against target: |
151 lines (+66/-48) 1 file modified
os/os-scrollbar.c (+66/-48) |
To merge this branch: | bzr merge lp:~charlesk/overlay-scrollbar/lp-1058205 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
jenkins (community) | continuous-integration | Approve | |
Thomas Bechtold (community) | Approve | ||
Andrea Cimitan | Approve | ||
Review via email: mp+128087@code.launchpad.net |
Description of the change
This is based off Thomas' fix-mem-leak-bug-1058205 branch.
While I was testing Thomas' branch, I noticed his test case reported the overlay scrollbar created these Priv structs while the scrollbars were being disposed. This has two problems -- first is the unnecessary work of creating and populating a Priv struct only to dispose it; but more importantly, we're allocating memory and setting it in an object's qdata after the object's been disposed.
So, this branch contains Thomas' slice_free() fix and also avoids creating Privs in our hijacked_
To post a comment you must log in.
Fine for me, there's an extra white line before the new static function :)