lp:~charlesk/libindicator/fix-939061

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:libindicator/0.5

Conor Curran (community): Approve on 2012-02-29

Diff: 28 lines (+3/-8)

1 file modified

libindicator/indicator-object.c (+3/-8)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #939061: Coverity PW.BRANCH_PAST_INITIALIZATION - CID 10615

Medium

Fix Released

Link a bug report

Related blueprints

454. By Charles Kerr on 2012-02-29

silence Coverity warning "PW.BRANCH_PAST_INITIALIZATION - CID 10615" reported in Bug #939061

Coverity is unhappy that the local variable "priv" is uninitialized if one of the goto branches is followed in this function. Since we only use priv once, a fairly clean way of sidestepping this warning is removing the local variable "priv" and instead using INDICATOR_OBJECT_GET_PRIVATE()'s return pointer directly.

453. By Charles Kerr on 2012-02-29

tweak: use g_clear_object() instead of if-not-null-g_object_unref()

452. By Ted Gould on 2012-02-23

0.4.92

451. By Ted Gould on 2012-02-23

Remove unenforcable consts

450. By Ted Gould on 2012-02-15

Adjusting timeout so it'll build on the buildds too

449. By Ted Gould on 2012-02-14

Explicitly listing gmodule as a library we're using

448. By Ted Gould on 2012-02-14

0.4.91

447. By Lars Karlitski on 2012-02-13

indicator_object_set_visible: only emit entry-{added,removed} when visibility actually changed

Emitting those signals is semantically incorrect. It also confused
indicator-loader and the panel, because they are not checking whether an entry
is already present in their entry-added handlers. This led to gtk warnings
("widget already has a parent") and strange effects, such as the same menu
being added multiple times into the panel.

This patch also makes indicator_object_dispose use indicator_object_set_visible
(it was already doing something similar).

446. By Ted Gould on 2012-02-10

Free groupname after usage

445. By Ted Gould on 2012-02-03

Be more agressive in ensureing the parent_object value is available everywhere.