Merge lp:~charlesk/libdbusmenu/lp-978687 into lp:libdbusmenu/0.6

Proposed by Charles Kerr
Status: Merged
Approved by: Charles Kerr
Approved revision: 414
Merged at revision: 417
Proposed branch: lp:~charlesk/libdbusmenu/lp-978687
Merge into: lp:libdbusmenu/0.6
Diff against target: 39 lines (+7/-7)
2 files modified
libdbusmenu-glib/Makefile.am (+3/-3)
libdbusmenu-gtk/Makefile.am (+4/-4)
To merge this branch: bzr merge lp:~charlesk/libdbusmenu/lp-978687
Reviewer Review Type Date Requested Status
Conor Curran (community) Approve
Review via email: mp+101656@code.launchpad.net

Description of the change

This branch applies Evan Nemerson's patch to make the Vala bindings use pkg-config names, rather than GIR names, so that valac can automatically pick up the relevant libraries and flags.

To post a comment you must log in.
Revision history for this message
Conor Curran (cjcurran) wrote :

Looks to be the sensible way forward. Once this ships, we will need to change the name of the vapi that is referenced in the makefile.am for i-sound so as the vala dbus hookup continues to work.

review: Approve
Revision history for this message
Ted Gould (ted) wrote :

Makes sense, but we should probably do that early in the 12.10 cycle instead of 12.04 at this point as packages would have to change and adjust to it.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'libdbusmenu-glib/Makefile.am'
2--- libdbusmenu-glib/Makefile.am 2012-04-04 02:33:03 +0000
3+++ libdbusmenu-glib/Makefile.am 2012-04-11 22:48:22 +0000
4@@ -216,10 +216,10 @@
5 if HAVE_INTROSPECTION
6
7 vapidir = $(datadir)/vala/vapi
8-vapi_DATA = Dbusmenu-0.4.vapi
9+vapi_DATA = dbusmenu-glib-0.4.vapi
10
11-Dbusmenu-0.4.vapi: Dbusmenu-0.4.gir
12- $(VALA_API_GEN) --library=Dbusmenu-0.4 $<
13+dbusmenu-glib-0.4.vapi: Dbusmenu-0.4.gir
14+ $(VALA_API_GEN) --library=dbusmenu-glib-0.4 $<
15
16 CLEANFILES += $(vapi_DATA)
17
18
19=== modified file 'libdbusmenu-gtk/Makefile.am'
20--- libdbusmenu-gtk/Makefile.am 2012-03-28 04:40:23 +0000
21+++ libdbusmenu-gtk/Makefile.am 2012-04-11 22:48:22 +0000
22@@ -160,14 +160,14 @@
23 if HAVE_INTROSPECTION
24
25 vapidir = $(datadir)/vala/vapi
26-vapi_DATA = DbusmenuGtk$(VER)-0.4.vapi
27+vapi_DATA = dbusmenu-gtk$(VER)-0.4.vapi
28
29-DbusmenuGtk$(VER)-0.4.vapi: DbusmenuGtk$(VER)-0.4.tmp.gir Makefile.am
30- $(VALA_API_GEN) --library=DbusmenuGtk$(VER)-0.4 \
31+dbusmenu-gtk$(VER)-0.4.vapi: DbusmenuGtk$(VER)-0.4.tmp.gir Makefile.am
32+ $(VALA_API_GEN) --library=dbusmenu-gtk$(VER)-0.4 \
33 --pkg gdk-pixbuf-2.0 \
34 --pkg $(GTKVALA) \
35 --pkg atk \
36- --pkg Dbusmenu-0.4 \
37+ --pkg dbusmenu-glib-0.4 \
38 --vapidir=$(top_builddir)/libdbusmenu-glib \
39 $<
40

Subscribers

People subscribed via source and target branches

to all changes: