Merge lp:~charlesk/libdbusmenu/compile-with-clang into lp:libdbusmenu/13.04

Proposed by Charles Kerr
Status: Merged
Approved by: Albert Astals Cid
Approved revision: 431
Merged at revision: 433
Proposed branch: lp:~charlesk/libdbusmenu/compile-with-clang
Merge into: lp:libdbusmenu/13.04
Diff against target: 37 lines (+5/-5)
2 files modified
libdbusmenu-glib/menuitem.c (+2/-2)
libdbusmenu-glib/server.c (+3/-3)
To merge this branch: bzr merge lp:~charlesk/libdbusmenu/compile-with-clang
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Albert Astals Cid (community) Approve
Review via email: mp+131599@code.launchpad.net

Commit message

when initializing fields inside a struct being declared, replace gccism with c99 syntax

Description of the change

when initializing fields inside a struct being declared, replace gccism with c99 syntax

To post a comment you must log in.
Revision history for this message
Albert Astals Cid (aacid) wrote :

Works fine :-)

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'libdbusmenu-glib/menuitem.c'
2--- libdbusmenu-glib/menuitem.c 2012-10-07 15:35:50 +0000
3+++ libdbusmenu-glib/menuitem.c 2012-10-26 12:42:24 +0000
4@@ -974,7 +974,7 @@
5 }
6 return mi;
7 }
8- find_id_t find_id = {mi: NULL, id: id};
9+ find_id_t find_id = {.mi=NULL, .id=id};
10 find_id_helper(mi, &find_id);
11 return find_id.mi;
12 }
13@@ -1712,7 +1712,7 @@
14
15 func(mi, data);
16 GList * children = dbusmenu_menuitem_get_children(mi);
17- foreach_struct_t foreach_data = {func: func, data: data};
18+ foreach_struct_t foreach_data = {.func=func, .data=data};
19 g_list_foreach(children, foreach_helper, &foreach_data);
20 return;
21 }
22
23=== modified file 'libdbusmenu-glib/server.c'
24--- libdbusmenu-glib/server.c 2012-10-07 15:35:50 +0000
25+++ libdbusmenu-glib/server.c 2012-10-26 12:42:24 +0000
26@@ -215,9 +215,9 @@
27 static GDBusNodeInfo * dbusmenu_node_info = NULL;
28 static GDBusInterfaceInfo * dbusmenu_interface_info = NULL;
29 static const GDBusInterfaceVTable dbusmenu_interface_table = {
30- method_call: bus_method_call,
31- get_property: bus_get_prop,
32- set_property: NULL /* No properties that can be set */
33+ .method_call = bus_method_call,
34+ .get_property = bus_get_prop,
35+ .set_property = NULL /* No properties that can be set */
36 };
37 static method_table_t dbusmenu_method_table[METHOD_COUNT];
38

Subscribers

People subscribed via source and target branches

to all changes: