Merge lp:~charlesk/libappindicator/fix-test-merge into lp:libappindicator/13.04

[Charles Kerr]

This is a continuation of ~mathieu-tl/libappindicator/fix-test-merge/ which adds fixes for bug #1102589, bug #1102595, bug #1109128, and bug #1103087, which should get it finally passing CI.

This is a continuation of ~mathieu-tl/libappindicator/fix-test-merge/ which adds fixes for bug #1102589, bug #1102595, bug #1109128, and bug #1103087, which should get it finally passing CI.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:253
http://jenkins.qa.ubuntu.com/job/libappindicator-ci/28/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/libappindicator-ci/./build=pbuilder,distribution=coverity-raring,flavor=amd64/28/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/libappindicator-ci/./build=pbuilder,distribution=raring,flavor=i386/28/console
Coverity artifacts:
    http://jenkins.qa.ubuntu.com/job/libappindicator-ci/./build=pbuilder,distribution=coverity-raring,flavor=amd64/28//artifact/results/coverity/NO_COVERITY_DEFECTS.txt
    http://jenkins.qa.ubuntu.com/job/libappindicator-ci/./build=pbuilder,distribution=raring,flavor=i386/28//artifact/results/coverity/NO_COVERITY_DEFECTS.txt

Click here to trigger a rebuild:
http://jenkins.qa.ubuntu.com/job/libappindicator-ci/28//rebuild/?

review: Approve (continuous-integration)

[Ted Gould (ted)]

review: Approve

=== modified file 'autogen.sh'
--- autogen.sh	2010-12-02 20:37:25 +0000
+++ autogen.sh	2013-01-29 18:17:22 +0000
@@ -7,6 +7,7 @@
 	exit 1
 }
 
+gtkdocize || exit 1
 USE_GNOME2_MACROS=1 \
 USE_COMMON_DOC_BUILD=yes \
 gnome-autogen.sh --enable-gtk-doc $@

=== modified file 'configure.ac'
--- configure.ac	2012-07-11 19:19:21 +0000
+++ configure.ac	2013-01-29 18:17:22 +0000
@@ -33,7 +33,7 @@
 # GTK Doc
 ###########################
 
-GTK_DOC_CHECK([1.9])
+GTK_DOC_CHECK([1.14],[--flavour no-tmpl])
 
 
 ###########################
@@ -42,7 +42,7 @@
 
 GTK_REQUIRED_VERSION=2.18
 GTK3_REQUIRED_VERSION=2.91
-GLIB_REQUIRED_VERSION=2.26
+GLIB_REQUIRED_VERSION=2.35.4
 GIO_REQUIRED_VERSION=2.26
 INDICATOR_REQUIRED_VERSION=0.4.93
 DBUSMENUGTK_REQUIRED_VERSION=0.5.90

=== modified file 'debian/changelog'
--- debian/changelog	2013-01-17 21:25:50 +0000
+++ debian/changelog	2013-01-29 18:17:22 +0000
@@ -1,11 +1,6 @@
 libappindicator (12.10.1-0ubuntu2) UNRELEASED; urgency=low
 
-  * acinclude.m4: Fix python multi-arch include issues. 
-
- -- Chris J Arges <[e-mail]>  Thu, 17 Jan 2013 15:25:28 -0600
-
-libappindicator (12.10.1-0ubuntu1) UNRELEASED; urgency=low
-
+  [ Mathieu Trudel-Lapierre ]
   * debian/control:
     - Update style: use trailing commas at the end of dependency lists.
     - Reorganize Build-Depends for clarity.
@@ -21,11 +16,15 @@
     - Add and export DPKG_GENSYMBOLS_CHECK_LEVEL.
     - Override dh_autoreconf to run autogen.sh and not call configure.
     - Override dh_auto_test to run tests per-flavor.
-    - Temporarily disable tests.
   * debian/*.install:
     - Update paths for multiarch and for use with dh9 (remove debian/tmp...)
-
- -- Mathieu Trudel-Lapierre <[e-mail]>  Mon, 26 Nov 2012 11:02:18 -0500
+  * Fix gtkdoc tests and building of the documentation given a separate build
+    directory.
+
+  [ Chris J Arges ]
+  * acinclude.m4: Fix python multi-arch include issues. 
+
+ -- Chris J Arges <[e-mail]>  Thu, 17 Jan 2013 15:25:28 -0600
 
 libappindicator (12.10.0-0ubuntu1) quantal; urgency=low
 

=== modified file 'debian/control'
--- debian/control	2012-11-27 14:51:20 +0000
+++ debian/control	2013-01-29 18:17:22 +0000
@@ -17,6 +17,7 @@
                xvfb,
                valac-0.16,
                mono-devel (>= 2.4.3),
+               libglib2.0-dev (>= 2.35.4),
                libgtk-3-dev (>= 2.91.3),
                libgtk2.0-dev (>= 2.12.0),
                python-gtk2-dev,

=== modified file 'debian/rules'
--- debian/rules	2012-12-04 17:01:40 +0000
+++ debian/rules	2013-01-29 18:17:22 +0000
@@ -20,6 +20,7 @@
 # Note: No cli here so that the pbuilder stuff works
 clean:
 	dh_clean
+	dh_autoreconf_clean
 
 override_dh_autoreconf:
 	NOCONFIGURE=1 dh_autoreconf ./autogen.sh
@@ -72,14 +73,19 @@
 override_dh_auto_test: $(FLAVORS:%=dotest-%)
 
 dotest-%:
-	#dh_auto_test --builddirectory=build/$*
+	ps -ef
+	env
+	dh_auto_test --builddirectory=build/$* --
+
 
 dotest-gtk2: $(PY_VERSIONS:%=dotestgtk2-%)
 	# GTK2 flavor test was run on a per-python-version basis.
 
 dotestgtk2-%:
-	#PYTHON=`which $*` \
-	#	dh_auto_test --builddirectory=build/gtk2
+	ps -ef
+	env
+	PYTHON=`which $*` \
+		dh_auto_test --builddirectory=build/gtk2 --
 
 override_dh_auto_clean:
 	dh_auto_clean

=== modified file 'docs/reference/Makefile.am'
--- docs/reference/Makefile.am	2011-02-11 04:03:01 +0000
+++ docs/reference/Makefile.am	2013-01-29 18:17:22 +0000
@@ -30,7 +30,7 @@
 # gtk-doc will search all .c & .h files beneath here for inline comments
 # documenting the functions and macros.
 # e.g. DOC_SOURCE_DIR=../../../gtk
-DOC_SOURCE_DIR=../../src
+DOC_SOURCE_DIR=$(top_srcdir)/src
 
 # Extra options to pass to gtkdoc-scangobj. Not normally needed.
 SCANGOBJ_OPTIONS=--nogtkinit --type-init-func="g_type_init()"
@@ -102,7 +102,7 @@
 GTKDOC_LIBS=$(top_builddir)/src/$(APPINDICATORLIB) $(LIBRARY_LIBS)
 
 # This includes the standard gtk-doc make rules, copied by gtkdocize.
-include $(top_srcdir)/gtk-doc.local.make
+include $(top_srcdir)/gtk-doc.make
 
 # Other files to distribute
 # e.g. EXTRA_DIST += version.xml.in
@@ -113,13 +113,11 @@
 # for --rebuild-sections in $(SCAN_OPTIONS) e.g. $(DOC_MODULE)-sections.txt
 #DISTCLEANFILES +=
 
-# Comment this out if you want your docs-status tested during 'make check'
-TESTS = gtkdoc-in-srcdir
-
-gtkdoc-in-srcdir: Makefile.am
-	@echo "#!/bin/sh" > $@
-	@echo "cd \"$(srcdir)\"" >> $@
-	@echo "$(GTKDOC_CHECK)" >> $@
-	@chmod +x $@
-DISTCLEANFILES = gtkdoc-in-srcdir
-
+# Comment this out if you want 'make check' to test you doc status
+# and run some sanity checks
+if ENABLE_GTK_DOC
+ TESTS_ENVIRONMENT = cd $(srcdir) && \
+   DOC_MODULE=$(DOC_MODULE) DOC_MAIN_SGML_FILE=$(DOC_MAIN_SGML_FILE) \
+   SRCDIR=$(abs_srcdir) BUILDDIR=$(abs_builddir)
+TESTS = $(GTKDOC_CHECK)
+endif

=== removed directory 'docs/reference/tmpl'
=== removed file 'docs/reference/tmpl/libappindicator-unused.sgml'
--- docs/reference/tmpl/libappindicator-unused.sgml	2011-02-24 04:21:55 +0000
+++ docs/reference/tmpl/libappindicator-unused.sgml	1970-01-01 00:00:00 +0000
@@ -1,42 +0,0 @@
-<!-- ##### MACRO APP_INDICATOR_SIGNAL_NEW_ACCESSIBLE_DESC ##### -->
-<para>
-
-</para>
-
-
-<!-- ##### SIGNAL AppIndicator::new-accessible-desc ##### -->
-<para>
-
-</para>
-
-@appindicator: the object which received the signal.
-@arg1: 
-
-<!-- ##### ARG AppIndicator:accessible-desc ##### -->
-<para>
-
-</para>
-
-
-<!-- ##### ARG AppIndicator:icon-path ##### -->
-<para>
-
-</para>
-
-
-<!-- ##### FUNCTION app_indicator_get_accessible_desc ##### -->
-<para>
-
-</para>
-
-@self: 
-@Returns: 
-
-<!-- ##### FUNCTION app_indicator_set_accessible_desc ##### -->
-<para>
-
-</para>
-
-@self: 
-@accessible_desc: 
-

=== removed file 'gtk-doc.local.make'
--- gtk-doc.local.make	2009-12-08 21:03:27 +0000
+++ gtk-doc.local.make	1970-01-01 00:00:00 +0000
@@ -1,194 +0,0 @@
-# -*- mode: makefile -*-
-
-####################################
-# Everything below here is generic #
-####################################
-
-if GTK_DOC_USE_LIBTOOL
-GTKDOC_CC = $(LIBTOOL) --mode=compile $(CC) $(INCLUDES) $(AM_CPPFLAGS) $(CPPFLAGS) $(AM_CFLAGS) $(CFLAGS)
-GTKDOC_LD = $(LIBTOOL) --mode=link $(CC) $(AM_CFLAGS) $(CFLAGS) $(AM_LDFLAGS) $(LDFLAGS)
-GTKDOC_RUN = $(LIBTOOL) --mode=execute
-else
-GTKDOC_CC = $(CC) $(INCLUDES) $(AM_CPPFLAGS) $(CPPFLAGS) $(AM_CFLAGS) $(CFLAGS)
-GTKDOC_LD = $(CC) $(AM_CFLAGS) $(CFLAGS) $(AM_LDFLAGS) $(LDFLAGS)
-GTKDOC_RUN = sh -c
-endif
-
-# We set GPATH here; this gives us semantics for GNU make
-# which are more like other make's VPATH, when it comes to
-# whether a source that is a target of one rule is then
-# searched for in VPATH/GPATH.
-#
-GPATH = $(srcdir)
-
-TARGET_DIR=$(HTML_DIR)/$(DOC_MODULE)
-
-EXTRA_DIST = 				\
-	$(content_files)		\
-	$(HTML_IMAGES)			\
-	$(DOC_MAIN_SGML_FILE)
-
-DOC_STAMPS=scan-build.stamp tmpl-build.stamp sgml-build.stamp html-build.stamp \
-	   $(srcdir)/tmpl.stamp $(srcdir)/sgml.stamp $(srcdir)/html.stamp
-
-SCANOBJ_FILES = 		 \
-	$(DOC_MODULE).args 	 \
-	$(DOC_MODULE).hierarchy  \
-	$(DOC_MODULE).interfaces \
-	$(DOC_MODULE).prerequisites \
-	$(DOC_MODULE).signals
-
-REPORT_FILES = \
-	$(DOC_MODULE)-undocumented.txt \
-	$(DOC_MODULE)-undeclared.txt \
-	$(DOC_MODULE)-unused.txt
-
-CLEANFILES = $(SCANOBJ_FILES) $(REPORT_FILES) $(DOC_STAMPS)
-
-if ENABLE_GTK_DOC
-all-local: html-build.stamp
-else
-all-local:
-endif
-
-docs: html-build.stamp
-
-$(REPORT_FILES): sgml-build.stamp
-
-#### scan ####
-
-scan-build.stamp: $(HFILE_GLOB) $(CFILE_GLOB)
-	@echo 'gtk-doc: Scanning header files'
-	@-chmod -R u+w $(srcdir)
-	cd $(srcdir) && \
-	  gtkdoc-scan --module=$(DOC_MODULE) --source-dir=$(DOC_SOURCE_DIR) --ignore-headers="$(IGNORE_HFILES)" $(SCAN_OPTIONS) $(EXTRA_HFILES)
-	if grep -l '^..*$$' $(srcdir)/$(DOC_MODULE).types > /dev/null 2>&1 ; then \
-	    CC="$(GTKDOC_CC)" LD="$(GTKDOC_LD)" RUN="$(GTKDOC_RUN)" CFLAGS="$(GTKDOC_CFLAGS) $(CFLAGS)" LDFLAGS="$(GTKDOC_LIBS) $(LDFLAGS)" gtkdoc-scangobj $(SCANGOBJ_OPTIONS) --module=$(DOC_MODULE) --output-dir=$(srcdir) ; \
-	else \
-	    cd $(srcdir) ; \
-	    for i in $(SCANOBJ_FILES) ; do \
-               test -f $$i || touch $$i ; \
-	    done \
-	fi
-	touch scan-build.stamp
-
-$(DOC_MODULE)-decl.txt $(SCANOBJ_FILES) $(DOC_MODULE)-sections.txt $(DOC_MODULE)-overrides.txt: scan-build.stamp
-	@true
-
-#### templates ####
-
-tmpl-build.stamp: $(DOC_MODULE)-decl.txt $(SCANOBJ_FILES) $(DOC_MODULE)-sections.txt $(DOC_MODULE)-overrides.txt
-	@echo 'gtk-doc: Rebuilding template files'
-	@-chmod -R u+w $(srcdir)
-	cd $(srcdir) && gtkdoc-mktmpl --module=$(DOC_MODULE) $(MKTMPL_OPTIONS)
-	touch tmpl-build.stamp
-
-tmpl.stamp: tmpl-build.stamp
-	@true
-
-tmpl/*.sgml:
-	@true
-
-
-#### xml ####
-
-sgml-build.stamp: tmpl.stamp $(HFILE_GLOB) $(CFILE_GLOB) $(DOC_MODULE)-sections.txt $(srcdir)/tmpl/*.sgml $(expand_content_files)
-	@echo 'gtk-doc: Building XML'
-	@-chmod -R u+w $(srcdir)
-	cd $(srcdir) && \
-	gtkdoc-mkdb --module=$(DOC_MODULE) --source-dir=$(DOC_SOURCE_DIR) --output-format=xml --expand-content-files="$(expand_content_files)" --main-sgml-file=$(DOC_MAIN_SGML_FILE) $(MKDB_OPTIONS)
-	touch sgml-build.stamp
-
-sgml.stamp: sgml-build.stamp
-	@true
-
-#### html ####
-
-html-build.stamp: sgml.stamp $(DOC_MAIN_SGML_FILE) $(content_files)
-	@echo 'gtk-doc: Building HTML'
-	@-chmod -R u+w $(srcdir)
-	rm -rf $(srcdir)/html
-	mkdir $(srcdir)/html
-	mkhtml_options=""; \
-	gtkdoc-mkhtml 2>&1 --help | grep  >/dev/null "\-\-path"; \
-	if test "$(?)" = "0"; then \
-	  mkhtml_options=--path="$(srcdir)"; \
-	fi
-	cd $(srcdir)/html && gtkdoc-mkhtml $(mkhtml_options) $(MKHTML_OPTIONS) $(DOC_MODULE) ../$(DOC_MAIN_SGML_FILE)
-	test "x$(HTML_IMAGES)" = "x" || ( cd $(srcdir) && cp $(HTML_IMAGES) html )
-	@echo 'gtk-doc: Fixing cross-references'
-	cd $(srcdir) && gtkdoc-fixxref --module-dir=html --html-dir=$(HTML_DIR) $(FIXXREF_OPTIONS)
-	touch html-build.stamp
-
-##############
-
-clean-local:
-	rm -f *~ *.bak
-	rm -rf .libs
-
-distclean-local:
-	cd $(srcdir) && \
-	  rm -rf xml $(REPORT_FILES) \
-	         $(DOC_MODULE)-decl-list.txt $(DOC_MODULE)-decl.txt
-
-maintainer-clean-local: clean
-	cd $(srcdir) && rm -rf xml html
-
-install-data-local:
-	installfiles=`echo $(srcdir)/html/*`; \
-	if test "$$installfiles" = '$(srcdir)/html/*'; \
-	then echo '-- Nothing to install' ; \
-	else \
-	  if test -n "$(DOC_MODULE_VERSION)"; then \
-	    installdir="$(DESTDIR)$(TARGET_DIR)-$(DOC_MODULE_VERSION)"; \
-	  else \
-	    installdir="$(DESTDIR)$(TARGET_DIR)"; \
-	  fi; \
-	  $(mkinstalldirs) $${installdir} ; \
-	  for i in $$installfiles; do \
-	    echo '-- Installing '$$i ; \
-	    $(INSTALL_DATA) $$i $${installdir}; \
-	  done; \
-	  if test -n "$(DOC_MODULE_VERSION)"; then \
-	    mv -f $${installdir}/$(DOC_MODULE).devhelp2 \
-	      $${installdir}/$(DOC_MODULE)-$(DOC_MODULE_VERSION).devhelp2; \
-	    mv -f $${installdir}/$(DOC_MODULE).devhelp \
-	      $${installdir}/$(DOC_MODULE)-$(DOC_MODULE_VERSION).devhelp; \
-	  fi; \
-	  ! which gtkdoc-rebase >/dev/null 2>&1 || \
-	    gtkdoc-rebase --relative --dest-dir=$(DESTDIR) --html-dir=$${installdir} ; \
-	fi
-
-uninstall-local:
-	if test -n "$(DOC_MODULE_VERSION)"; then \
-	  installdir="$(DESTDIR)$(TARGET_DIR)-$(DOC_MODULE_VERSION)"; \
-	else \
-	  installdir="$(DESTDIR)$(TARGET_DIR)"; \
-	fi; \
-	rm -rf $${installdir}
-
-#
-# Require gtk-doc when making dist
-#
-if ENABLE_GTK_DOC
-dist-check-gtkdoc:
-else
-dist-check-gtkdoc:
-	@echo "*** gtk-doc must be installed and enabled in order to make dist"
-	@false
-endif
-
-dist-hook: dist-check-gtkdoc dist-hook-local
-	mkdir $(distdir)/tmpl
-	mkdir $(distdir)/xml
-	mkdir $(distdir)/html
-	-cp $(srcdir)/tmpl/*.sgml $(distdir)/tmpl
-	-cp $(srcdir)/xml/*.xml $(distdir)/xml
-	-cp $(srcdir)/html/* $(distdir)/html
-	-cp $(srcdir)/$(DOC_MODULE).types $(distdir)/
-	-cp $(srcdir)/$(DOC_MODULE)-sections.txt $(distdir)/
-	cd $(distdir) && rm -f $(DISTCLEANFILES)
-	! which gtkdoc-rebase >/dev/null 2>&1 || \
-	  gtkdoc-rebase --online --relative --html-dir=$(distdir)/html
-
-.PHONY : dist-hook-local docs

=== modified file 'src/app-indicator.c'
--- src/app-indicator.c	2012-07-11 19:19:21 +0000
+++ src/app-indicator.c	2013-01-29 18:17:22 +0000
@@ -1886,20 +1886,14 @@
 	gboolean changed = FALSE;
 
 	if (g_strcmp0 (self->priv->attention_icon_name, icon_name) != 0) {
-		if (self->priv->attention_icon_name) {
-			g_free (self->priv->attention_icon_name);
-		}
-
-		self->priv->attention_icon_name = g_strdup(icon_name);
+		g_free (self->priv->attention_icon_name);
+		self->priv->attention_icon_name = g_strdup (icon_name);
 		changed = TRUE;
 	}
 
 	if (g_strcmp0(self->priv->att_accessible_desc, icon_desc) != 0) {
-		if (self->priv->att_accessible_desc) {
-			g_free (self->priv->att_accessible_desc);
-		}
-
-		self->priv->att_accessible_desc = g_strdup(icon_name);
+		g_free (self->priv->att_accessible_desc);
+		self->priv->att_accessible_desc = g_strdup (icon_desc);
 		changed = TRUE;
 	}
 
@@ -1910,12 +1904,12 @@
 			GError * error = NULL;
 
 			g_dbus_connection_emit_signal(self->priv->connection,
-										  NULL,
-										  self->priv->path,
-										  NOTIFICATION_ITEM_DBUS_IFACE,
-										  "NewAttentionIcon",
-										  NULL,
-										  &error);
+			                              NULL,
+			                              self->priv->path,
+			                              NOTIFICATION_ITEM_DBUS_IFACE,
+			                              "NewAttentionIcon",
+			                              NULL,
+			                              &error);
 
 			if (error != NULL) {
 				g_warning("Unable to send signal for NewAttentionIcon: %s", error->message);

=== modified file 'src/generate-id.c'
--- src/generate-id.c	2010-12-08 17:00:54 +0000
+++ src/generate-id.c	2013-01-29 18:17:22 +0000
@@ -65,5 +65,5 @@
 		}
 	}
 
-	return (((((category * 256) + first) * 256) + second) * 256) + third;
+	return (((((category << 8) + first) << 8) + second) << 8) + third;
 }

=== modified file 'tests/Makefile.am'
--- tests/Makefile.am	2011-02-11 04:14:28 +0000
+++ tests/Makefile.am	2013-01-29 18:17:22 +0000
@@ -137,6 +137,8 @@
 
 test-libappindicator-fallback: test-libappindicator-fallback-watcher test-libappindicator-fallback-item Makefile.am
 	@echo "#!/bin/bash" > $@
+	@echo export DISPLAY= >> $@
+	@echo killall at-spi2-registryd >> $@
 	@echo . $(srcdir)/run-xvfb.sh >> $@
 	@echo $(DBUS_RUNNER) --task ./test-libappindicator-fallback-watcher --task-name Watcher --ignore-return --task ./test-libappindicator-fallback-item --task-name Item >> $@
 	@chmod +x $@
@@ -152,6 +154,8 @@
 
 libappindicator-tests: libappindicator-tests-gtester Makefile.am
 	@echo "#!/bin/bash" > $@
+	@echo export DISPLAY= >> $@
+	@echo killall at-spi2-registryd >> $@
 	@echo . $(srcdir)/run-xvfb.sh >> $@
 	@echo export UBUNTU_MENUPROXY= >> $@
 	@echo $(DBUS_RUNNER) --task ./libappindicator-tests-gtester >> $@
@@ -166,10 +170,12 @@
 DISTCLEANFILES += $(XML_REPORT) $(HTML_REPORT) libappindicator-tests-gtester
 
 
-DBUS_RUNNER=dbus-test-runner --dbus-config /usr/share/dbus-test-runner/session.conf
+DBUS_RUNNER=dbus-test-runner -m 300 --dbus-config /usr/share/dbus-test-runner/session.conf
 
 test-libappindicator-dbus: test-libappindicator-dbus-client test-libappindicator-dbus-server Makefile.am
 	@echo "#!/bin/bash" > test-libappindicator-dbus
+	@echo export DISPLAY= >> $@
+	@echo killall at-spi2-registryd >> $@
 	@echo . $(srcdir)/run-xvfb.sh >> $@
 	@echo $(DBUS_RUNNER) --task ./test-libappindicator-dbus-client --task-name Client --task ./test-libappindicator-dbus-server --task-name Server --ignore-return >> test-libappindicator-dbus
 	@chmod +x test-libappindicator-dbus
@@ -179,6 +185,8 @@
 
 test-libappindicator-status: test-libappindicator-status-client test-libappindicator-status-server Makefile.am
 	@echo "#!/bin/bash" > test-libappindicator-status
+	@echo export DISPLAY= >> $@
+	@echo killall at-spi2-registryd >> $@
 	@echo . $(srcdir)/run-xvfb.sh >> $@
 	@echo $(DBUS_RUNNER) --task ./test-libappindicator-status-client --task-name Client --task ./test-libappindicator-status-server --task-name Server --ignore-return >> test-libappindicator-status
 	@chmod +x test-libappindicator-status

=== modified file 'tests/test-libappindicator-dbus-client.c'
--- tests/test-libappindicator-dbus-client.c	2010-12-08 16:54:16 +0000
+++ tests/test-libappindicator-dbus-client.c	2013-01-29 18:17:22 +0000
@@ -204,8 +204,6 @@
 gint
 main (gint argc, gchar * argv[])
 {
-	g_type_init();
-
 	GError * error = NULL;
 	DBusGConnection * session_bus = dbus_g_bus_get(DBUS_BUS_SESSION, &error);
 	if (error != NULL) {

=== modified file 'tests/test-libappindicator-fallback-item.c'
--- tests/test-libappindicator-fallback-item.c	2010-06-11 17:34:09 +0000
+++ tests/test-libappindicator-fallback-item.c	2013-01-29 18:17:22 +0000
@@ -138,7 +138,7 @@
 	GtkWidget * menu = gtk_menu_new();
 	app_indicator_set_menu(APP_INDICATOR(item), GTK_MENU(menu));
 
-	g_timeout_add_seconds(2, kill_func, NULL);
+	g_timeout_add_seconds(20, kill_func, NULL);
 
 	mainloop = g_main_loop_new(NULL, FALSE);
 	g_main_loop_run(mainloop);

=== modified file 'tests/test-libappindicator-fallback-watcher.c'
--- tests/test-libappindicator-fallback-watcher.c	2010-06-11 17:35:21 +0000
+++ tests/test-libappindicator-fallback-watcher.c	2013-01-29 18:17:22 +0000
@@ -58,8 +58,6 @@
 int
 main (int argv, char ** argc)
 {
-	g_type_init();
-
 	g_debug("Waiting to init.");
 
 
@@ -77,6 +75,7 @@
 	while (!has_owner && owner_count < 10000) {
 		org_freedesktop_DBus_name_has_owner(bus_proxy, "org.test", &has_owner, NULL);
 		owner_count++;
+		g_usleep(500000);
 	}
 
 	if (owner_count == 10000) {
@@ -104,7 +103,7 @@
 
 	/* This is the final kill function.  It really shouldn't happen
 	   unless we get an error. */
-	g_timeout_add(2000, kill_func, NULL);
+	g_timeout_add_seconds(20, kill_func, NULL);
 
 	g_debug("Entering Mainloop");
 

=== modified file 'tests/test-libappindicator-status-client.c'
--- tests/test-libappindicator-status-client.c	2010-03-02 20:31:37 +0000
+++ tests/test-libappindicator-status-client.c	2013-01-29 18:17:22 +0000
@@ -109,8 +109,6 @@
 gint
 main (gint argc, gchar * argv[])
 {
-	g_type_init();
-
 	GError * error = NULL;
 	DBusGConnection * session_bus = dbus_g_bus_get(DBUS_BUS_SESSION, &error);
 	if (error != NULL) {
@@ -118,7 +116,7 @@
 		return 1;
 	}
 
-    DBusGProxy * bus_proxy = dbus_g_proxy_new_for_name(session_bus, DBUS_SERVICE_DBUS, DBUS_PATH_DBUS, DBUS_INTERFACE_DBUS);
+	DBusGProxy * bus_proxy = dbus_g_proxy_new_for_name(session_bus, DBUS_SERVICE_DBUS, DBUS_PATH_DBUS, DBUS_INTERFACE_DBUS);
 	guint nameret = 0;
 
 	if (!org_freedesktop_DBus_request_name(bus_proxy, NOTIFICATION_WATCHER_DBUS_ADDR, 0, &nameret, &error)) {
@@ -137,7 +135,7 @@
 	dbus_bus_add_match(dbus_g_connection_get_connection(session_bus), "type='signal',interface='" NOTIFICATION_ITEM_DBUS_IFACE "',member='NewStatus'", NULL);
 
 	watchdog_hit = TRUE;
-	g_timeout_add(1000, kill_func, NULL);
+	g_timeout_add_seconds(20, kill_func, NULL);
 
 	mainloop = g_main_loop_new(NULL, FALSE);
 	g_main_loop_run(mainloop);

=== modified file 'tests/test-libappindicator-status-server.c'
--- tests/test-libappindicator-status-server.c	2010-04-29 16:31:36 +0000
+++ tests/test-libappindicator-status-server.c	2013-01-29 18:17:22 +0000
@@ -22,34 +22,39 @@
 
 
 #include <stdlib.h>
-#include <dbus/dbus-glib.h>
-#include <dbus/dbus-glib-lowlevel.h>
 #include <glib.h>
 #include <app-indicator.h>
 
 static GMainLoop * mainloop = NULL;
 static gboolean active = FALSE;
 static guint toggle_count = 0;
+static GDBusConnection * connection = NULL;
+
+static gboolean
+times_up (gpointer unused G_GNUC_UNUSED)
+{
+	g_dbus_connection_flush_sync (connection, NULL, NULL);
+	g_clear_object (&connection);
+
+	g_main_loop_quit (mainloop);
+	return G_SOURCE_REMOVE;
+}
 
 gboolean
 toggle (gpointer userdata)
 {
-	if (active) {
-		app_indicator_set_status (APP_INDICATOR(userdata), APP_INDICATOR_STATUS_ATTENTION);
-		active = FALSE;
-	} else {
-		app_indicator_set_status (APP_INDICATOR(userdata), APP_INDICATOR_STATUS_ACTIVE);
-		active = TRUE;
-	}
-
-	toggle_count++;
+	const AppIndicatorStatus new_status = active ? APP_INDICATOR_STATUS_ATTENTION
+                                                 : APP_INDICATOR_STATUS_ACTIVE;
+	app_indicator_set_status (APP_INDICATOR(userdata), new_status);
+	++toggle_count;
+	active = !active;
 
 	if (toggle_count == 100) {
-		g_main_loop_quit(mainloop);
-		return FALSE;
+		g_timeout_add (100, times_up, NULL);
+		return G_SOURCE_REMOVE;
 	}
 
-	return TRUE;
+	return G_SOURCE_CONTINUE;
 }
 
 gint
@@ -59,7 +64,8 @@
 
 	g_usleep(100000);
 
-	g_debug("DBus ID: %s", dbus_connection_get_server_id(dbus_g_connection_get_connection(dbus_g_bus_get(DBUS_BUS_SESSION, NULL))));
+	connection = g_bus_get_sync (G_BUS_TYPE_SESSION, NULL, NULL);
+	g_debug("DBus Name: %s", g_dbus_connection_get_unique_name (connection));
 
 	AppIndicator * ci = app_indicator_new ("my-id", "my-icon-name", APP_INDICATOR_CATEGORY_APPLICATION_STATUS);
 	app_indicator_set_attention_icon (ci, "my-attention-icon");
@@ -76,6 +82,7 @@
 	g_main_loop_run(mainloop);
 
 	g_object_unref(G_OBJECT(ci));
+
 	g_debug("Quiting");
 
 	return 0;

=== modified file 'tests/test-libappindicator.c'
--- tests/test-libappindicator.c	2012-01-29 03:42:34 +0000
+++ tests/test-libappindicator.c	2013-01-29 18:17:22 +0000
@@ -28,6 +28,16 @@
 #include <libdbusmenu-glib/menuitem.h>
 #include <libdbusmenu-glib/server.h>
 
+static gboolean
+allow_warnings (const gchar *log_domain, GLogLevelFlags log_level,
+                const gchar *message, gpointer user_data)
+{
+	// By default, gtest will fail a test on even a warning message.
+	// But since some of our sub-libraries are noisy (especially at-spi2),
+	// only fail on critical or worse.
+	return ((log_level & G_LOG_LEVEL_MASK) <= G_LOG_LEVEL_CRITICAL);
+}
+
 void
 test_libappindicator_prop_signals_status_helper (AppIndicator * ci, gchar * status, gboolean * signalactivated)
 {
@@ -45,6 +55,8 @@
 void
 test_libappindicator_prop_signals (void)
 {
+	g_test_log_set_fatal_handler (allow_warnings, NULL);
+
         AppIndicator * ci = app_indicator_new ("test-app-indicator",
                                                "indicator-messages",
                                                APP_INDICATOR_CATEGORY_APPLICATION_STATUS);
@@ -115,6 +127,8 @@
 void
 test_libappindicator_init_set_props (void)
 {
+	g_test_log_set_fatal_handler (allow_warnings, NULL);
+
         AppIndicator * ci = app_indicator_new ("my-id",
                                                "my-name",
                                                APP_INDICATOR_CATEGORY_APPLICATION_STATUS);
@@ -139,6 +153,8 @@
 void
 test_libappindicator_init_with_props (void)
 {
+	g_test_log_set_fatal_handler (allow_warnings, NULL);
+
         AppIndicator * ci = app_indicator_new ("my-id",
                                                "my-name",
                                                APP_INDICATOR_CATEGORY_APPLICATION_STATUS);
@@ -161,6 +177,8 @@
 void
 test_libappindicator_init (void)
 {
+	g_test_log_set_fatal_handler (allow_warnings, NULL);
+
         AppIndicator * ci = app_indicator_new ("my-id", "my-name", APP_INDICATOR_CATEGORY_APPLICATION_STATUS);
 	g_assert(ci != NULL);
 	g_object_unref(G_OBJECT(ci));
@@ -170,6 +188,8 @@
 void
 test_libappindicator_set_label (void)
 {
+	g_test_log_set_fatal_handler (allow_warnings, NULL);
+
 	AppIndicator * ci = app_indicator_new ("my-id",
 	                                       "my-name",
 	                                       APP_INDICATOR_CATEGORY_APPLICATION_STATUS);
@@ -232,6 +252,8 @@
 void
 test_libappindicator_set_menu (void)
 {
+	g_test_log_set_fatal_handler (allow_warnings, NULL);
+
 	AppIndicator * ci = app_indicator_new ("my-id",
 	                                       "my-name",
 	                                       APP_INDICATOR_CATEGORY_APPLICATION_STATUS);
@@ -301,6 +323,8 @@
 void
 test_libappindicator_label_signals (void)
 {
+	g_test_log_set_fatal_handler (allow_warnings, NULL);
+
 	gint label_signals_count = 0;
 	AppIndicator * ci = app_indicator_new ("my-id",
 	                                       "my-name",
@@ -352,6 +376,8 @@
 void
 test_libappindicator_desktop_menu (void)
 {
+	g_test_log_set_fatal_handler (allow_warnings, NULL);
+
 	AppIndicator * ci = app_indicator_new ("my-id-desktop-menu",
 	                                       "my-name",
 	                                       APP_INDICATOR_CATEGORY_APPLICATION_STATUS);
@@ -388,6 +414,8 @@
 void
 test_libappindicator_desktop_menu_bad (void)
 {
+	g_test_log_set_fatal_handler (allow_warnings, NULL);
+
 	AppIndicator * ci = app_indicator_new ("my-id-desktop-menu-bad",
 	                                       "my-name",
 	                                       APP_INDICATOR_CATEGORY_APPLICATION_STATUS);

=== modified file 'tests/test-simple-app.c'
--- tests/test-simple-app.c	2010-04-29 16:31:36 +0000
+++ tests/test-simple-app.c	2013-01-29 18:17:22 +0000
@@ -31,8 +31,6 @@
 int
 main (int argc, char ** argv)
 {
-	g_type_init();
-
 	DbusmenuServer * dms = dbusmenu_server_new("/menu");
 	DbusmenuMenuitem * dmi = dbusmenu_menuitem_new();
 	dbusmenu_menuitem_property_set(dmi, "label", "Bob");