Merge lp:~charlesk/keeper/get-coverage-reports-working into lp:keeper
Status: | Merged |
---|---|
Merge reported by: | Charles Kerr |
Merged at revision: | not available |
Proposed branch: | lp:~charlesk/keeper/get-coverage-reports-working |
Merge into: | lp:keeper |
Diff against target: |
716 lines (+375/-189) 14 files modified
CMakeLists.txt (+2/-1) HACKING (+64/-0) src/CMakeLists.txt (+6/-0) src/helper/CMakeLists.txt (+21/-9) src/service/CMakeLists.txt (+14/-0) src/storage-framework/CMakeLists.txt (+22/-5) src/tar/CMakeLists.txt (+29/-21) tests/CMakeLists.txt (+6/-0) tests/unit/CMakeLists.txt (+37/-66) tests/unit/helper/CMakeLists.txt (+103/-45) tests/unit/metadata-providers/CMakeLists.txt (+29/-0) tests/unit/storage/test-factory.cpp (+0/-29) tests/unit/tar/CMakeLists.txt (+29/-0) tests/utils/CMakeLists.txt (+13/-13) |
To merge this branch: | bzr merge lp:~charlesk/keeper/get-coverage-reports-working |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Xavi Garcia (community) | Approve | ||
Review via email: mp+300833@code.launchpad.net |
Commit message
Get coverage reports working.
Description of the change
Does what it says on the tin: coverage reports now work.
1. Added cmake variable COVERAGE_
2. Added cmake variable UNIT_TEST_TARGETS which gets appended to by the subdirectories in tests/ with parent scope so so it, too, is visible to enable_
3. Recursively building UNIT_TEST_TARGETS means we no longer have to have a single 'unit-tests' executable, so break the unit tests into standalone executables. This was the secondary goal of this branch -- making it easier to run a single unit test again and again during a debugging cycle
4. Minor copyediting: use more consistent spacing (eg 2 spaces vs 4) in the CMakeLists.txt files, use target_
I think you forgot to add/commit a couple of files:
CMake Error at tests/unit/ CMakeLists. txt:33 (add_subdirectory):
The source directory
/tmp/ get-coverage- reports- working/ tests/unit/ metadata- providers
does not contain a CMakeLists.txt file.
CMake Error at tests/unit/ CMakeLists. txt:34 (add_subdirectory):
The source directory
/tmp/ get-coverage- reports- working/ tests/unit/ tar
does not contain a CMakeLists.txt file.