Merge lp:~charlesk/indicator-sync/lp-1103087 into lp:indicator-sync/13.04

Proposed by Charles Kerr
Status: Merged
Approved by: Mathieu Trudel-Lapierre
Approved revision: 30
Merged at revision: 30
Proposed branch: lp:~charlesk/indicator-sync/lp-1103087
Merge into: lp:indicator-sync/13.04
Diff against target: 73 lines (+2/-7)
6 files modified
configure.ac (+1/-1)
debian/control (+1/-1)
examples/sync-app-example.c (+0/-1)
src/service/sync-service.c (+0/-2)
test/test-client.cpp (+0/-1)
test/test-gtest.cpp (+0/-1)
To merge this branch: bzr merge lp:~charlesk/indicator-sync/lp-1103087
Reviewer Review Type Date Requested Status
Mathieu Trudel-Lapierre Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+144384@code.launchpad.net

Description of the change

Removes g_type_init() calls and bumps the glib prerequisite to 2.35.4

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Approve

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'configure.ac'
2--- configure.ac 2012-11-08 17:29:38 +0000
3+++ configure.ac 2013-01-22 20:18:23 +0000
4@@ -50,7 +50,7 @@
5 INDICATOR_REQUIRED_VERSION=0.3.19
6 DBUSMENUGLIB_REQUIRED_VERSION=.0.6.2
7 DBUSMENUGTK_REQUIRED_VERSION=0.5.90
8-GLIB_REQUIRED_VERSION=2.32.0
9+GLIB_REQUIRED_VERSION=2.35.4
10
11 PKG_CHECK_MODULES(SYNC_LIB_DEPS, [dbusmenu-glib-0.4 >= $DBUSMENUGLIB_REQUIRED_VERSION
12 gio-unix-2.0 >= $GIO_UNIX_REQUIRED_VERSION
13
14=== modified file 'debian/control'
15--- debian/control 2012-11-21 16:30:56 +0000
16+++ debian/control 2013-01-22 20:18:23 +0000
17@@ -11,7 +11,7 @@
18 gobject-introspection,
19 libgirepository1.0-dev,
20 libgtk-3-dev,
21- libglib2.0-dev (>= 2.32.0),
22+ libglib2.0-dev (>= 2.35.4),
23 libindicator3-dev,
24 libdbusmenu-glib-dev (>= 0.6.2),
25 libdbusmenu-gtk3-dev (>= 0.5.90),
26
27=== modified file 'examples/sync-app-example.c'
28--- examples/sync-app-example.c 2012-08-25 20:27:47 +0000
29+++ examples/sync-app-example.c 2013-01-22 20:18:23 +0000
30@@ -211,7 +211,6 @@
31 int
32 main (void)
33 {
34- g_type_init ();
35 create_u1_sync_menu_app ();
36 g_main_loop_run (g_main_loop_new(NULL, FALSE));
37 return 0;
38
39=== modified file 'src/service/sync-service.c'
40--- src/service/sync-service.c 2012-09-17 05:18:18 +0000
41+++ src/service/sync-service.c 2013-01-22 20:18:23 +0000
42@@ -643,8 +643,6 @@
43 bindtextdomain (GETTEXT_PACKAGE, GNOMELOCALEDIR);
44 textdomain (GETTEXT_PACKAGE);
45
46- g_type_init ();
47-
48 sync_service.skeleton = dbus_sync_service_skeleton_new ();
49
50 g_bus_get (G_BUS_TYPE_SESSION, NULL, on_got_bus, &sync_service);
51
52=== modified file 'test/test-client.cpp'
53--- test/test-client.cpp 2012-09-21 23:17:22 +0000
54+++ test/test-client.cpp 2013-01-22 20:18:23 +0000
55@@ -31,7 +31,6 @@
56 static bool ran_once_init = false;
57 if (!ran_once_init)
58 {
59- g_type_init();
60 g_setenv ("INDICATOR_SERVICE_SHUTDOWN_TIMEOUT", "5000", TRUE);
61 g_unsetenv ("INDICATOR_ALLOW_NO_WATCHERS");
62 g_unsetenv ("INDICATOR_SERVICE_REPLACE_MODE");
63
64=== modified file 'test/test-gtest.cpp'
65--- test/test-gtest.cpp 2012-08-19 07:00:07 +0000
66+++ test/test-gtest.cpp 2013-01-22 20:18:23 +0000
67@@ -7,6 +7,5 @@
68 }
69
70 TEST(LauncherMenuItem, NameInitialized) {
71- g_type_init();
72 EXPECT_TRUE(true);
73 }

Subscribers

People subscribed via source and target branches