lp:~charlesk/indicator-sound/lp-1481913-integrate-settings-and-clamp-volume
Created by
Charles Kerr
and last modified
- Get this branch:
- bzr branch lp:~charlesk/indicator-sound/lp-1481913-integrate-settings-and-clamp-volume
Only
Charles Kerr
can upload to this branch. If you are
Charles Kerr
please log in for upload directions.
Branch merges
Propose for merging
No branches
dependent on this one.
- Antti Kaijanmäki (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 856 lines (+356/-175)7 files modifieddata/com.canonical.indicator.sound.gschema.xml (+58/-34)
src/service.vala (+112/-106)
src/volume-control-pulse.vala (+161/-22)
src/volume-control.vala (+13/-1)
tests/CMakeLists.txt (+0/-2)
tests/notifications-test.cc (+8/-8)
tests/volume-control-mock.vala (+4/-2)
Related source package recipes
Related bugs
| Bug #1468680: The warning dialog is doesn't presented | Undecided | Fix Released |
|
| Bug #1481913: UI volume warnings need revision | Critical | Fix Released |
|
Related blueprints
Branch information
Recent revisions
- 525. By Charles Kerr
-
copyediting: in new code, use unowned strings where practical, slightly better comments, more consistent method names
- 523. By Charles Kerr
-
in tests/media-
player- user, re-disable the DataSet and TimeoutTests. This failure is not related to the new code and should be handled separately. - 522. By Charles Kerr
-
in volume-
control- pulse's update_ high_volume_ approved_ timer() , fix timer interval - 519. By Charles Kerr
-
in tests/volume-
control- mock, add a public method for setting max-volume so that we can re-enable those tests in notifications-test - 518. By Charles Kerr
-
fix circular reference loop that prevented Service from being destructed properly
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:indicator-sound/15.10
