Merge lp:~charlesk/indicator-session/remove-g-type-init into lp:indicator-session/13.04

Proposed by Charles Kerr
Status: Merged
Approved by: Mathieu Trudel-Lapierre
Approved revision: 382
Merge reported by: Mathieu Trudel-Lapierre
Merged at revision: not available
Proposed branch: lp:~charlesk/indicator-session/remove-g-type-init
Merge into: lp:indicator-session/13.04
Diff against target: 50 lines (+2/-5)
4 files modified
configure.ac (+1/-1)
debian/control (+1/-1)
src/session-service.c (+0/-2)
tests/test-service.cc (+0/-1)
To merge this branch: bzr merge lp:~charlesk/indicator-session/remove-g-type-init
Reviewer Review Type Date Requested Status
Mathieu Trudel-Lapierre Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+143776@code.launchpad.net

Description of the change

remove g_type_init() calls and bump glib minimum to 2.35.4, where g_type_init() is deprecated

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Approve.

review: Approve
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Somehow that wasn't getting merged by Jenkins, I ended up reproducing the changes on my end, I didn't remember...

Marking as Merged so that we get it off the list now.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'configure.ac'
2--- configure.ac 2012-11-30 16:24:17 +0000
3+++ configure.ac 2013-01-17 21:32:26 +0000
4@@ -26,7 +26,7 @@
5 ###########################
6
7 GIO_REQUIRED_VERSION=2.33
8-GLIB_REQUIRED_VERSION=2.33
9+GLIB_REQUIRED_VERSION=2.35.4
10 GTK_REQUIRED_VERSION=3.0
11 INDICATOR_REQUIRED_VERSION=0.3.19
12 DBUSMENUGTK_REQUIRED_VERSION=0.5.90
13
14=== modified file 'debian/control'
15--- debian/control 2013-01-15 22:52:32 +0000
16+++ debian/control 2013-01-17 21:32:26 +0000
17@@ -11,7 +11,7 @@
18 libdbustest1-dev,
19 dbus-test-runner,
20 libgtk-3-dev,
21- libglib2.0-dev (>= 2.33),
22+ libglib2.0-dev (>= 2.35.4),
23 gnome-doc-utils,
24 libindicator3-dev (>= 0.3.90),
25 libdbusmenu-glib-dev (>= 0.5.90),
26
27=== modified file 'src/session-service.c'
28--- src/session-service.c 2012-08-31 17:37:39 +0000
29+++ src/session-service.c 2013-01-17 21:32:26 +0000
30@@ -71,8 +71,6 @@
31 int
32 main (int argc, char ** argv)
33 {
34- g_type_init();
35-
36 /* Setting up i18n and gettext.
37 Apparently we need all of these. */
38 setlocale (LC_ALL, "");
39
40=== modified file 'tests/test-service.cc'
41--- tests/test-service.cc 2012-11-13 20:08:13 +0000
42+++ tests/test-service.cc 2013-01-17 21:32:26 +0000
43@@ -49,7 +49,6 @@
44 static bool first_run = true;
45 if (first_run)
46 {
47- g_type_init();
48 g_setenv ("INDICATOR_SERVICE_SHUTDOWN_TIMEOUT", "1000", TRUE);
49 g_unsetenv ("INDICATOR_ALLOW_NO_WATCHERS");
50 g_unsetenv ("INDICATOR_SERVICE_REPLACE_MODE");

Subscribers

People subscribed via source and target branches