Merge lp:~charlesk/indicator-session/lp-1354058-use-standard-translations-cmake-file into lp:indicator-session/14.10

[Charles Kerr]

Re-use the same Translations.cmake file across indicators

Sync Translations.cmake with the bugfixed version that recently landed in indicator-datetime.

Discussion @ https://code.launchpad.net/~charlesk/indicator-datetime/lp-1354058-include-cpp-files-when-invoking-xgettext/+merge/229976

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:453
http://jenkins.qa.ubuntu.com/job/indicator-session-ci/144/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-session-utopic-amd64-ci/8/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-session-utopic-armhf-ci/8/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-session-ci/144/rebuild

review: Needs Fixing (continuous-integration)

[Charles Kerr (charlesk)]

Looks like ths 2014-08-09 build failure came from a gcovr bug introduced in 3.1,<https://github.com/gcovr/gcovr/issues/37> which just landed in utopic. mterry's now backported the fix from 3.2 <https://launchpad.net/ubuntu/+source/gcovr/3.1-1ubuntu1>

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:453
http://jenkins.qa.ubuntu.com/job/indicator-session-ci/145/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-session-utopic-amd64-ci/9
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-session-utopic-armhf-ci/9
        deb: http://jenkins.qa.ubuntu.com/job/indicator-session-utopic-armhf-ci/9/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-session-ci/145/rebuild

review: Approve (continuous-integration)

[Ted Gould (ted)]

review: Approve

=== modified file 'cmake/Translations.cmake'
--- cmake/Translations.cmake	2013-07-02 00:26:11 +0000
+++ cmake/Translations.cmake	2014-08-09 23:40:11 +0000
@@ -10,7 +10,7 @@
         add_custom_command (TARGET i18n COMMAND ${MSGFMT_EXECUTABLE} -o ${MO_OUTPUT} ${PO_INPUT})
 
         install (FILES ${MO_OUTPUT} DESTINATION
-            ${CMAKE_INSTALL_LOCALEDIR}/LC_MESSAGES
+            ${CMAKE_INSTALL_LOCALEDIR}/${PO_INPUT_BASE}/LC_MESSAGES
             RENAME ${NLS_PACKAGE}.mo)
     endforeach (PO_INPUT ${PO_FILES})
 endmacro(add_translations_directory)
@@ -20,22 +20,18 @@
     add_custom_target (pot COMMENT “Building translation catalog.”)
     find_program (XGETTEXT_EXECUTABLE xgettext)
 
-
-    set(C_SOURCE "")
-
+    # init this list, which will hold all the sources across all dirs
+    set(SOURCES "")
+
+    # add each directory's sources to the overall sources list
     foreach(FILES_INPUT ${ARGN})
-        file (GLOB_RECURSE SOURCE_FILES ${CMAKE_CURRENT_SOURCE_DIR}/${FILES_INPUT}/*.c)
-        foreach(C_FILE ${SOURCE_FILES})
-            set(C_SOURCE ${C_SOURCE} ${C_FILE})
-        endforeach()
-        file (GLOB_RECURSE SOURCE_FILES ${CMAKE_CURRENT_SOURCE_DIR}/${FILES_INPUT}/*.vala)
-        foreach(C_FILE ${SOURCE_FILES})
-            set(C_SOURCE ${C_SOURCE} ${C_FILE})
-        endforeach()
+        set (DIR ${CMAKE_CURRENT_SOURCE_DIR}/${FILES_INPUT})
+        file (GLOB_RECURSE DIR_SOURCES ${DIR}/*.c ${DIR}/*.cc ${DIR}/*.cpp ${DIR}/*.cxx ${DIR}/*.vala)
+	set (SOURCES ${SOURCES} ${DIR_SOURCES})
     endforeach()
 
     add_custom_command (TARGET pot COMMAND
         ${XGETTEXT_EXECUTABLE} -d ${NLS_PACKAGE} -o ${CMAKE_CURRENT_SOURCE_DIR}/${NLS_PACKAGE}.pot
-        ${VALA_SOURCE} ${C_SOURCE} --keyword="_" --keyword="N_" --from-code=UTF-8
+        ${SOURCES} --keyword="_" --keyword="N_" --from-code=UTF-8
         )
 endmacro()