Merge lp:~charlesk/indicator-session/lp-1256590-j-random-user into lp:indicator-session/14.04
Proposed by
Charles Kerr
Status: | Merged |
---|---|
Approved by: | Ted Gould |
Approved revision: | 446 |
Merged at revision: | 443 |
Proposed branch: | lp:~charlesk/indicator-session/lp-1256590-j-random-user |
Merge into: | lp:indicator-session/14.04 |
Diff against target: |
365 lines (+266/-10) 5 files modified
debian/control (+1/-0) src/CMakeLists.txt (+2/-0) src/recoverable-problem.c (+167/-0) src/recoverable-problem.h (+26/-0) src/service.c (+70/-10) |
To merge this branch: | bzr merge lp:~charlesk/indicator-session/lp-1256590-j-random-user |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot (community) | continuous-integration | Approve | |
Ted Gould (community) | Approve | ||
Review via email: mp+213353@code.launchpad.net |
Commit message
Fix the phantom "J Random User" menuitem that shows up under some conditions.
Description of the change
This patch skips creating menuitems for users that don't have a username.
Sometimes org.freedesktop
So we pass a NULL label to glib when we create the menuitem, and when the label property is NULL for an x-canonical-type of "indicator.
To post a comment you must log in.
PASSED: Continuous integration, rev:444 jenkins. qa.ubuntu. com/job/ indicator- session- ci/127/ jenkins. qa.ubuntu. com/job/ indicator- session- trusty- amd64-ci/ 23 jenkins. qa.ubuntu. com/job/ indicator- session- trusty- armhf-ci/ 23 jenkins. qa.ubuntu. com/job/ indicator- session- trusty- armhf-ci/ 23/artifact/ work/output/ *zip*/output. zip
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/indicator- session- ci/127/ rebuild
http://