Merge lp:~charlesk/indicator-session/lp-1076271 into lp:indicator-session/13.04

Proposed by Charles Kerr
Status: Merged
Approved by: Lars Karlitski
Approved revision: 373
Merged at revision: 375
Proposed branch: lp:~charlesk/indicator-session/lp-1076271
Merge into: lp:indicator-session/13.04
Diff against target: 17 lines (+4/-3)
1 file modified
src/session-menu-mgr.c (+4/-3)
To merge this branch: bzr merge lp:~charlesk/indicator-session/lp-1076271
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Lars Karlitski (community) Approve
Review via email: mp+134532@code.launchpad.net

Commit message

Show the login name if an account has no real name set

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Allan LeSage (allanlesage) wrote :

Needed the inline packaging to land first; please proceed with reviews and set to "approve" at will.

Revision history for this message
Lars Karlitski (larsu) wrote :

Looks & works great, thanks.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
No commit message was specified.

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/session-menu-mgr.c'
2--- src/session-menu-mgr.c 2012-11-06 15:08:31 +0000
3+++ src/session-menu-mgr.c 2012-11-15 17:41:23 +0000
4@@ -700,9 +700,10 @@
5 GString * gstr = g_string_new (accounts_user_get_real_name (user));
6
7 if (user_has_name_collision (user))
8- {
9- g_string_append_printf (gstr, " (%s)", accounts_user_get_user_name(user));
10- }
11+ g_string_append_printf (gstr, " (%s)", accounts_user_get_user_name(user));
12+
13+ if (!gstr->len)
14+ g_string_assign (gstr, accounts_user_get_user_name(user));
15
16 dbusmenu_menuitem_property_set (mi, USER_ITEM_PROP_NAME, gstr->str);
17 g_string_free (gstr, TRUE);

Subscribers

People subscribed via source and target branches