Merge lp:~charlesk/indicator-session/lp-1061844 into lp:indicator-session/12.10

Proposed by Charles Kerr
Status: Merged
Approved by: Ted Gould
Approved revision: 367
Merged at revision: 367
Proposed branch: lp:~charlesk/indicator-session/lp-1061844
Merge into: lp:indicator-session/12.10
Diff against target: 46 lines (+19/-15)
1 file modified
src/session-menu-mgr.c (+19/-15)
To merge this branch: bzr merge lp:~charlesk/indicator-session/lp-1061844
Reviewer Review Type Date Requested Status
Ted Gould (community) Approve
jenkins (community) continuous-integration Approve
Review via email: mp+129002@code.launchpad.net

Commit message

Test upower_proxy for NULL before using it.

To post a comment you must log in.
Revision history for this message
jenkins (martin-mrazik+qa) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ted Gould (ted) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/session-menu-mgr.c'
--- src/session-menu-mgr.c 2012-10-01 17:39:38 +0000
+++ src/session-menu-mgr.c 2012-10-10 17:31:24 +0000
@@ -247,23 +247,27 @@
247static void247static void
248on_upower_properties_changed (SessionMenuMgr * mgr)248on_upower_properties_changed (SessionMenuMgr * mgr)
249{249{
250 gboolean b;
251 gboolean need_refresh = FALSE;250 gboolean need_refresh = FALSE;
252251
253 /* suspend */252 if (mgr->upower_proxy != NULL)
254 b = dbus_upower_get_can_suspend (mgr->upower_proxy);253 {
255 if (mgr->can_suspend != b)254 gboolean b;
256 {255
257 mgr->can_suspend = b;256 /* suspend */
258 need_refresh = TRUE;257 b = dbus_upower_get_can_suspend (mgr->upower_proxy);
259 }258 if (mgr->can_suspend != b)
260259 {
261 /* hibernate */260 mgr->can_suspend = b;
262 b = dbus_upower_get_can_hibernate (mgr->upower_proxy);261 need_refresh = TRUE;
263 if (mgr->can_hibernate != b)262 }
264 {263
265 mgr->can_hibernate = b;264 /* hibernate */
266 need_refresh = TRUE;265 b = dbus_upower_get_can_hibernate (mgr->upower_proxy);
266 if (mgr->can_hibernate != b)
267 {
268 mgr->can_hibernate = b;
269 need_refresh = TRUE;
270 }
267 }271 }
268272
269 if (need_refresh)273 if (need_refresh)

Subscribers

People subscribed via source and target branches