Merge lp:~charlesk/indicator-session/lp-1049902 into lp:indicator-session/12.10

Proposed by Charles Kerr on 2012-09-19
Status: Merged
Approved by: Lars Karlitski on 2012-09-19
Approved revision: 360
Merged at revision: 360
Proposed branch: lp:~charlesk/indicator-session/lp-1049902
Merge into: lp:indicator-session/12.10
Diff against target: 11 lines (+0/-2)
1 file modified
src/indicator-session.c (+0/-2)
To merge this branch: bzr merge lp:~charlesk/indicator-session/lp-1049902
Reviewer Review Type Date Requested Status
Lars Karlitski (community) 2012-09-19 Approve on 2012-09-19
jenkins (community) continuous-integration Approve on 2012-09-19
Review via email: mp+125077@code.launchpad.net

Commit message

Don't unconditionally show the user menuitems -- let dbusmenu's code process the menuitem's VISIBLE property

To post a comment you must log in.
jenkins (martin-mrazik+qa) wrote :
review: Approve (continuous-integration)
Lars Karlitski (larsu) wrote :

Looks very reasonable.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/indicator-session.c'
2--- src/indicator-session.c 2012-09-13 13:27:35 +0000
3+++ src/indicator-session.c 2012-09-19 00:13:20 +0000
4@@ -313,8 +313,6 @@
5 g_debug ("%s (\"%s\")", __func__,
6 dbusmenu_menuitem_property_get (newitem,
7 USER_ITEM_PROP_NAME));
8- gtk_widget_show_all (user_item);
9-
10 return TRUE;
11 }
12

Subscribers

People subscribed via source and target branches