Merge lp:~charlesk/indicator-power/lp-1296431-low-power-snap-decisions into lp:indicator-power/14.10
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Ted Gould | ||||
Approved revision: | 261 | ||||
Merged at revision: | 260 | ||||
Proposed branch: | lp:~charlesk/indicator-power/lp-1296431-low-power-snap-decisions | ||||
Merge into: | lp:indicator-power/14.10 | ||||
Diff against target: |
148 lines (+69/-8) 2 files modified
src/notifier.c (+62/-4) tests/indicator-power-service-cmdline-battery.cc (+7/-4) |
||||
To merge this branch: | bzr merge lp:~charlesk/indicator-power/lp-1296431-low-power-snap-decisions | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ted Gould (community) | Approve | ||
PS Jenkins bot (community) | continuous-integration | Approve | |
Review via email: mp+233744@code.launchpad.net |
Commit message
When the phone's battery goes down past a certain level, pop up a snap decision to warn the user.
Description of the change
== Description of the Change
When the battery charge level goes down past the predefined thresholds,
show this on the phone: https:/
and this on the desktop: https:/
NB: the phone warnings wireframe at https:/
== Checklist
> Are there any related MPs required for this MP to build/function as expected? Please list.
No
> Is your branch in sync with latest trunk? (e.g. bzr pull lp:trunk -> no changes)
Yes
> Did the code build without warnings?
Yes
> Did the tests run successfully?
Yes
> Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
> If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
> Did your component test plan pass? If on a device, what image number?
mako + rtm r29
> Did you provide a link to this page https:/
Yes
> Please list which manual tests are germane for the reviewer in this MR.
New test: indicator-
FAILED: Continuous integration, rev:258 jenkins. qa.ubuntu. com/job/ indicator- power-ci/ 127/ jenkins. qa.ubuntu. com/job/ indicator- power-utopic- amd64-ci/ 28/console jenkins. qa.ubuntu. com/job/ indicator- power-utopic- armhf-ci/ 28 jenkins. qa.ubuntu. com/job/ indicator- power-utopic- armhf-ci/ 28/artifact/ work/output/ *zip*/output. zip
http://
Executed test runs:
FAILURE: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/indicator- power-ci/ 127/rebuild
http://