lp:~charlesk/indicator-power/lp-1066208

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:indicator-power/13.04 at revision 151

Lars Karlitski (community): Approve on 2012-10-26

PS Jenkins bot (community): Approve (continuous-integration) on 2012-10-26

Diff: 779 lines (+402/-233)

5 files modified

src/device.c (+18/-14)
src/indicator-power.c (+94/-71)
src/indicator-power.h (+2/-0)
tests/test-device.cc (+274/-148)
tests/test-indicator.cc (+14/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1066208: power indicator shows a mouse battery as a laptop battery	High	Fix Released
Bug #1071645: indicator-power doesn't always choose the correct primary device	Medium	Fix Released

Link a bug report

Related blueprints

157. By Charles Kerr on 2012-10-26

fix copy-paste comment error

156. By Charles Kerr on 2012-10-26

fix comment typo

155. By Charles Kerr on 2012-10-26

Select the primary device based on the spec's criteria. Add tests to confirm.

154. By Charles Kerr on 2012-10-26

silence the known/nonbug gtk and glib warnings

153. By Charles Kerr on 2012-10-26

add unit tests to confirm the device refcounts are correct s.t. IndicatorPower isn't leaking devices

152. By Charles Kerr on 2012-10-26

fix leaked icon and label; found by running valgrind on tests/test-indicator

151. By Charles Kerr on 2012-10-26

Fix unhandled enum 'unknown device' that was smoked out by the unit tests.

150. By Charles Kerr on 2012-10-25

the device kind string wasn't being used in some icon names.

149. By Charles Kerr on 2012-10-03

merge lp:~charlesk/indicator-power/lp-1054146 to give a more accurate view of discharging batteries

148. By Lars Karlitski on 2012-09-26

Merge lp:~/larsu/indicator-power/plug-get-icon-memory-leak

Plugs a small memory leak in indicator-power.c