Merge lp:~charlesk/indicator-messages/lp-1377286-update-indicator-title-strings into lp:indicator-messages/13.10

Proposed by Charles Kerr
Status: Merged
Approved by: Ted Gould
Approved revision: 422
Merged at revision: 424
Proposed branch: lp:~charlesk/indicator-messages/lp-1377286-update-indicator-title-strings
Merge into: lp:indicator-messages/13.10
Diff against target: 25 lines (+2/-2)
2 files modified
src/im-application-list.c (+1/-1)
tests/manual (+1/-1)
To merge this branch: bzr merge lp:~charlesk/indicator-messages/lp-1377286-update-indicator-title-strings
Reviewer Review Type Date Requested Status
Ted Gould (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+237136@code.launchpad.net

Commit message

Make title string match updated designs.

Description of the change

== Description of the Change

No behavior changes. Only changes the phone header's title from "Notification center" to "Notifications" as per the "Indicators - RTM Usability Fixes" document.

== Checklist

> Are there any related MPs required for this MP to build/function as expected? Please list.

No

> Is your branch in sync with latest trunk? (e.g. bzr pull lp:trunk -> no changes)

Yes

> Did the code build without warnings?

Yes

> Did the tests run successfully?

Yes

> Did you perform an exploratory manual test run of your code change and any related functionality?

Yes

> If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?

N/A

> What device (or emulator) has your component test plan been executed successfully on?

mako + r68

> What manual tests are relevant for this MP?

indicator-messages/unity8-items-check

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ted Gould (ted) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/im-application-list.c'
2--- src/im-application-list.c 2014-09-16 14:58:47 +0000
3+++ src/im-application-list.c 2014-10-03 20:25:30 +0000
4@@ -194,7 +194,7 @@
5 g_object_unref(icon);
6
7 /* title */
8- g_variant_builder_add (&builder, "{sv}", "title", g_variant_new_string (_("Notification center")));
9+ g_variant_builder_add (&builder, "{sv}", "title", g_variant_new_string (_("Notifications")));
10
11 /* accessible description */
12 g_variant_builder_open(&builder, G_VARIANT_TYPE_DICT_ENTRY);
13
14=== modified file 'tests/manual'
15--- tests/manual 2014-07-30 22:33:13 +0000
16+++ tests/manual 2014-10-03 20:25:30 +0000
17@@ -17,7 +17,7 @@
18 <dl>
19 <dt>Login to a user session running Unity 8</dt>
20 <dt>Pull down the top panel until it sticks open</dt>
21- <dt>Navigate through the tabs until "Notification center" is shown</dt>
22+ <dt>Navigate through the tabs until "Notifications" is shown</dt>
23 <dd>Incoming is at the top of the menu</dd>
24 <dd>The menu is populated with items</dd>
25 </dl>

Subscribers

People subscribed via source and target branches