Merge lp:~charlesk/indicator-messages/lp-1234895 into lp:~indicator-applet-developers/indicator-messages/trunk.13.10

Proposed by Charles Kerr
Status: Merged
Approved by: Ted Gould
Approved revision: 388
Merged at revision: 388
Proposed branch: lp:~charlesk/indicator-messages/lp-1234895
Merge into: lp:~indicator-applet-developers/indicator-messages/trunk.13.10
Diff against target: 20 lines (+2/-1)
1 file modified
src/im-application-list.c (+2/-1)
To merge this branch: bzr merge lp:~charlesk/indicator-messages/lp-1234895
Reviewer Review Type Date Requested Status
Ted Gould (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+189169@code.launchpad.net

Commit message

in im_application_list_update_draws_attention(), free the temporary icon_name string created by g_strdup_printf()

Description of the change

in im_application_list_update_draws_attention(), free the temporary icon_name string created by g_strdup_printf()

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ted Gould (ted) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/im-application-list.c'
2--- src/im-application-list.c 2013-10-02 11:33:09 +0000
3+++ src/im-application-list.c 2013-10-03 19:43:32 +0000
4@@ -159,7 +159,7 @@
5 {
6 const gchar *base_icon_name;
7 const gchar *accessible_name;
8- const gchar *icon_name;
9+ gchar *icon_name;
10 GIcon * icon;
11 GVariant *serialized_icon;
12 GVariantBuilder builder;
13@@ -184,6 +184,7 @@
14
15 /* icon */
16 icon = g_themed_icon_new_with_default_fallbacks(icon_name);
17+ g_free(icon_name);
18 if ((serialized_icon = g_icon_serialize(icon)))
19 {
20 g_variant_builder_add (&builder, "{sv}", "icon", serialized_icon);

Subscribers

People subscribed via source and target branches